test: 💍 harden test to work on Windows#1264
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts Volume.watch() tests around throwIfNoEntry: false to better reflect platform-specific path traversal behavior (Windows vs POSIX) and to ensure non-ENOENT errors still surface.
Changes:
- Updates the “suppresses only ENOENT” test to use a permission-denied scenario (
EACCES) instead of a normal existing file. - Splits traversal-through-file behavior into explicit POSIX (
ENOTDIR) vs Windows (ENOENTsuppressed) test cases. - Adds a Windows-specific test asserting that the watcher is returned (and can be closed) when traversal reports
ENOENT.
Comment on lines
+1646
to
+1648
| const vol = Volume.fromJSON({ '/file.txt': 'x' }, undefined, { | ||
| process: { ...process, platform: 'linux' }, | ||
| }); |
Comment on lines
+1653
to
+1655
| const vol = Volume.fromJSON({ '/file.txt': 'x' }, undefined, { | ||
| process: { ...process, platform: 'win32' }, | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.