Skip to content

Node-to-FSA watcher bridge#1267

Merged
streamich merged 7 commits into
masterfrom
node-to-fsa-watcher-bridge
Jul 7, 2026
Merged

Node-to-FSA watcher bridge#1267
streamich merged 7 commits into
masterfrom
node-to-fsa-watcher-bridge

Conversation

@streamich

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings July 7, 2026 13:33

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a Node.js fs.watch-backed FileSystemObserver implementation to the fs-node-to-fsa bridge, and verifies end-to-end watcher behavior when chaining fs-node-to-fsafs-fsa-to-node.

Changes:

  • Introduces NodeFileSystemObserver (best-effort FileSystemObserver over fs.watch) and exports it from the package entrypoint.
  • Adds unit tests for NodeFileSystemObserver plus an integration test that verifies fs.watch events propagate across both bridges.
  • Updates READMEs to document watcher support and the FileSystemObserver-based implementation model.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
packages/fs-node-to-fsa/src/NodeFileSystemObserver.ts New FileSystemObserver implementation backed by fs.watch, producing change records.
packages/fs-node-to-fsa/src/index.ts Exports the new observer from the public API.
packages/fs-node-to-fsa/src/tests/NodeFileSystemObserver.test.ts Unit coverage for create/modify/delete/rename, recursion, errors, and lifecycle methods.
packages/fs-node-to-fsa/README.md Documents NodeFileSystemObserver usage and behavior limitations.
packages/fs-fsa-to-node/src/tests/watch-chain.test.ts Integration test to ensure fs.watch signals traverse both adapters.
packages/fs-fsa-to-node/README.md Documents watcher support and how FileSystemObserver is selected/injected.

Comment thread packages/fs-node-to-fsa/src/NodeFileSystemObserver.ts
Comment thread packages/fs-node-to-fsa/src/NodeFileSystemObserver.ts Outdated
Comment thread packages/fs-node-to-fsa/src/NodeFileSystemObserver.ts

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Comment thread packages/fs-node-to-fsa/src/NodeFileSystemObserver.ts Outdated
Comment thread packages/fs-node-to-fsa/src/NodeFileSystemObserver.ts
@streamich streamich merged commit 5a3feb7 into master Jul 7, 2026
9 checks passed
@streamich streamich deleted the node-to-fsa-watcher-bridge branch July 7, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants