Node-to-FSA watcher bridge#1267
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a Node.js fs.watch-backed FileSystemObserver implementation to the fs-node-to-fsa bridge, and verifies end-to-end watcher behavior when chaining fs-node-to-fsa → fs-fsa-to-node.
Changes:
- Introduces
NodeFileSystemObserver(best-effortFileSystemObserveroverfs.watch) and exports it from the package entrypoint. - Adds unit tests for
NodeFileSystemObserverplus an integration test that verifiesfs.watchevents propagate across both bridges. - Updates READMEs to document watcher support and the
FileSystemObserver-based implementation model.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/fs-node-to-fsa/src/NodeFileSystemObserver.ts | New FileSystemObserver implementation backed by fs.watch, producing change records. |
| packages/fs-node-to-fsa/src/index.ts | Exports the new observer from the public API. |
| packages/fs-node-to-fsa/src/tests/NodeFileSystemObserver.test.ts | Unit coverage for create/modify/delete/rename, recursion, errors, and lifecycle methods. |
| packages/fs-node-to-fsa/README.md | Documents NodeFileSystemObserver usage and behavior limitations. |
| packages/fs-fsa-to-node/src/tests/watch-chain.test.ts | Integration test to ensure fs.watch signals traverse both adapters. |
| packages/fs-fsa-to-node/README.md | Documents watcher support and how FileSystemObserver is selected/injected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.