Emit reverted value-transfer balance changes for precompile calls - #18
Merged
sduchesneau merged 2 commits intoJul 9, 2026
Merged
Conversation
A tx sending value to a precompile that then runs out of gas reverts the transfer. revm truncates the BalanceTransfer journal entry on rollback before call_end's journal walk runs, and precompiles never step, so both balance changes were dropped — geth reports them. Capture the non-self transfer at call-enter in pending_value_transfer, cleared by process_journal_changes once the journal entry is emitted (stepping or successful no-step callee). If it survives to call_end the call reverted, so re-emit it synthetically from the post-rollback (= pre-transfer) balances, unless the call aborted before the transfer (OutOfFunds / CallTooDeep). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…e-reverted-value-transfer-balance-changes # Conflicts: # crates/firehose/src/inspector.rs
sduchesneau
deleted the
fix/precompile-reverted-value-transfer-balance-changes
branch
July 9, 2026 13:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A tx sending value to a precompile that then runs out of gas reverts the
transfer. revm truncates the BalanceTransfer journal entry on rollback
before call_end's journal walk runs, and precompiles never step, so both
balance changes were dropped — geth reports them.
Capture the non-self transfer at call-enter in pending_value_transfer,
cleared by process_journal_changes once the journal entry is emitted
(stepping or successful no-step callee). If it survives to call_end the
call reverted, so re-emit it synthetically from the post-rollback (=
pre-transfer) balances, unless the call aborted before the transfer
(OutOfFunds / CallTooDeep).
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com