Sync with upstream java-tron 4.8.2 protos (GreatVoyage-v4.8.2.1) - #8
Merged
Conversation
sync with java-tron 4.8.2
Brings in the protos shipped with java-tron GreatVoyage-v4.8.2, which are
also the protos shipped with GreatVoyage-v4.8.2.1 (that release is
dependency bumps only and carries no proto change of its own).
Upstream changes in this range:
- api/api.proto: dropped all (google.api.http) grpc-gateway annotations
and the google/api/annotations.proto import ("improve HTTP API
performance"). No RPC, message, field or enum changed.
- api/api.proto: marked IvkDecryptTRC20Parameters.events and
OvkDecryptTRC20Parameters.events as deprecated, fixed a comment typo.
- core/Tron.proto, core/Discover.proto: one blank line removed each.
- core/tron/*.proto: 8 empty placeholder files deleted (this fork had
already removed them).
- Protocol documentation refreshed.
Wire-compatible: no message, field or enum definition changed.
The protos no longer import google/api/annotations.proto, so: - removed buf.build/googleapis/googleapis from buf.yaml / buf.lock - google.golang.org/genproto/googleapis/api is no longer needed in go.mod Regenerated pb/api with 'buf generate'. pb/core is unchanged. The generated Go API surface is identical: same exported types, methods and gRPC client/server interfaces. Only the embedded file descriptor (the removed HTTP annotations) and doc comments changed, plus a Deprecated marker on IvkDecryptTRC20Parameters.GetEvents and OvkDecryptTRC20Parameters.GetEvents.
billettc
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs this fork with upstream
tronprotocol/protocolat8432beca("Merge pull request tronprotocol#256 from halibobo1205/release_4.8.2"), so it carries the protos shipped with java-tron GreatVoyage-v4.8.2.1.GreatVoyage-v4.8.2.1is a dependency-bump release (libp2p 2.2.8 -> 2.2.9, grpc-java 1.81.0 -> 1.83.0) plus HTTP API performance work. It contains no proto change of its own, and upstream has no 4.8.2.1 sync commit — its HEAD is still the 4.8.2 merge. So syncing to8432becais what "support 4.8.2.1" means at the proto level.Previous sync point was upstream
4c726956(java-tron 4.8.1).Upstream changes in this range
api/api.proto: alloption (google.api.http) = {...}grpc-gateway annotations removed from the service definitions, and theimport "google/api/annotations.proto";line dropped. This is the "improve HTTP API performance" item.api/api.proto:IvkDecryptTRC20Parameters.eventsandOvkDecryptTRC20Parameters.eventsmarked[deprecated = true];shiededTransactioncomment typo fixed.core/Tron.proto,core/Discover.proto: a single blank line removed each.core/tron/*.proto: 8 empty placeholder files deleted upstream. This fork had already removed them, so nothing to do.Verified: the RPC list is byte-for-byte identical between
4c726956and8432beca, and no message, field or enum definition changed. This is wire-compatible.Changes in this PR
8432beca. Merged cleanly — no conflicts. All StreamingFast deltas are preserved: thego_packagerewrites,core/contract/*.protoflattened intocore/, thepb/bindings,buf.*config and.github/workflows.buf.build/googleapis/googleapisremoved frombuf.yamlandbuf.lock, since no proto importsgoogle/api/annotations.protoany more.google.golang.org/genproto/googleapis/apicorrespondingly dropped fromgo.mod.pb/apiregenerated withbuf generate.pb/coreis unchanged.core/tron/*.protofiles" bullet — upstream removed them too, so it is no longer a divergence.Impact on the generated Go API
The exported surface is identical — same types, same methods, same gRPC client/server interfaces. Diffing exported
type/funcdeclarations before and after regeneration produces no output for bothapi.pb.goandapi_grpc.pb.go.What actually changed in
pb/api:shieldedTransactiontypo fix);// Deprecated:markers onIvkDecryptTRC20Parameters.GetEvents()andOvkDecryptTRC20Parameters.GetEvents();protoc-gen-go-grpcversion commentv1.6.1->v1.6.2.Nothing here breaks
firehose-tron, which importspb/apiandpb/core.Verification
buf build— OKgo build ./...— OKgo test ./...— OKgo vet ./...— OKbuf generateis idempotent on the committed tree, andgo mod tidyis a no-op.Follow-ups after merge (not done here)
.github/workflows/buf.ymlonly triggers ontags: v*, so aGreatVoyage-v4.8.2.1tag alone will not publish to the BSR — the plainv4.8.2.1tag is the one that runsbuf push --label=main.CHANGELOG.mdwas added: this repo has never had one and uses release tags to map fork versions to java-tron versions.