-
Notifications
You must be signed in to change notification settings - Fork 635
Make llms-full autogen on deploy #1324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
netlify.toml
Outdated
| @@ -1,14 +1,18 @@ | |||
| [build] | |||
| command = "npm export" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this supposed to be npm run export?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooops, it's make export. Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The whole fix in this PR is that Netlify now calls make export instead of npm run export. And make export depends on make llms, which builds llms-full.txt
|
Can we delete both llm context files in this PR so they don't clutter up the repo? (llm-full.txt and content_catalog.json) |
|
Since we have to get uv into the environment to fix the build errors, should we try bumping the runtime while we're at it? It's still on Python 3.8. https://github.com/streamlit/docs/blob/main/runtime.txt |
sfc-gh-dmatthews
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the uv dependency and checked that the llms_full file is available in the preview.
📚 Context
docs.streamlit.io/llms-full.txtneeds to be rebuilt every time the site is modified. Today that's done withmake export. But it turns out that Netlify doesn't runmake export, and instead it just callsnpm run exportdirectly. So this PR addresses that.🧠 Description of Changes
Make Netlify call
make exportwhen building the site. This is being done innetlify.tomlrather than in the Netlify GUI because the GUI was complaining. See video below.Screen.Recording.2025-08-15.at.15.16.02.mov
💥 Impact
Size:
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.