Skip to content

feat(ci): improve image detection at PR time #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sfc-gh-bnisco merged 1 commit into from
May 5, 2026
Merged

feat(ci): improve image detection at PR time #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions .github/workflows/validate-component-definitions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,28 @@ jobs:
run: |
set -euo pipefail
uv run python components/registry/scripts/validate.py

- name: Fetch base branch
run: git fetch --no-tags --depth=1 origin "${{ github.base_ref }}"

- name: Validate Changed Component Images
run: |
set -euo pipefail

mapfile -t files < <(
git diff --name-only --diff-filter=ACMR "origin/${{ github.base_ref }}"...HEAD -- "components/registry/components/*.json"
)

if (( ${#files[@]} == 0 )); then
echo "No changed component definition files to image-check."
exit 0
fi

tmpdir="$(mktemp -d)"
trap 'rm -rf "${tmpdir}"' EXIT

for file in "${files[@]}"; do
cp "${file}" "${tmpdir}/"
done

uv run python components/registry/scripts/enrich_images.py --check-only --components-dir "${tmpdir}"