[test] Add testing for v1 and v2 #41
Merged
+67
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 20, 2025
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Nov 20, 2025
Merged
sfc-gh-bnisco
force-pushed
the
feat-ccv2-dual-v2
branch
from
59294b7 to
477e5fc
Compare
sfc-gh-bnisco
force-pushed
the
feat-ccv2-dual-test
branch
2 times, most recently
from
c4af6e0 to
3b3e96b
Compare
sfc-gh-bnisco
force-pushed
the
feat-ccv2-dual-v2
branch
from
477e5fc to
f80cff3
Compare
Copilot finished reviewing on behalf of
sfc-gh-bnisco
November 20, 2025 18:41
There was a problem hiding this comment.
Pull Request Overview
This PR adds matrix testing for Streamlit Custom Component v1 and v2 APIs by testing against both Streamlit 1.50.0 (v1) and the latest version (v2).
Key Changes:
- Enabled Custom Component v2 API based on Streamlit version (≥1.51.0)
- Added GitHub Actions matrix strategy to test both Streamlit 1.50.0 and latest
- Updated Playwright tests to detect and handle both iframe-based (v1) and inline (v2) component rendering
Reviewed Changes
Copilot reviewed 4 out of 100 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
streamlit_bokeh/__init__.py |
Uncommented version-gated v2 API activation logic |
e2e_playwright/conftest.py |
Added version detection function and v2 fixture, updated snapshot naming for v2 |
e2e_playwright/bokeh_chart_basics_test.py |
Added conditional test logic for v1 (iframe) vs v2 (inline) selectors |
.github/workflows/playwright.yml |
Added matrix strategy for testing multiple Streamlit versions |
e2e_playwright/__snapshots__/**/*.png |
Added new v2 snapshot reference images |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...ics_test/bokeh_chart-color_scatter-standard-width[light_theme-chromium-color_scatter-v2].png
Show resolved
Hide resolved
sfc-gh-nbellante
approved these changes
Nov 20, 2025
sfc-gh-nbellante
left a comment
sfc-gh-nbellante
left a comment
There was a problem hiding this comment.
Couple non-blocking questions
sfc-gh-bnisco
force-pushed
the
feat-ccv2-dual-test
branch
from
3b3e96b to
b3240c9
Compare
sfc-gh-bnisco
force-pushed
the
feat-ccv2-dual-v2
branch
from
f80cff3 to
96140c3
Compare
sfc-gh-bnisco
force-pushed
the
feat-ccv2-dual-test
branch
from
b3240c9 to
c95faab
Compare
sfc-gh-bnisco
force-pushed
the
feat-ccv2-dual-v2
branch
from
96140c3 to
ea36266
Compare
sfc-gh-bnisco
force-pushed
the
feat-ccv2-dual-v2
branch
from
ea36266 to
19a4b62
Compare
sfc-gh-bnisco
force-pushed
the
feat-ccv2-dual-test
branch
from
c95faab to
141de7c
Compare
sfc-gh-bnisco
changed the base branch from
feat-ccv2-dual-v2
to
graphite-base/41
sfc-gh-bnisco
force-pushed
the
graphite-base/41
branch
from
19a4b62 to
c33bf59
Compare
sfc-gh-bnisco
force-pushed
the
feat-ccv2-dual-test
branch
from
141de7c to
684d3da
Compare
sfc-gh-bnisco
force-pushed
the
feat-ccv2-dual-test
branch
3 times, most recently
from
dee5c67 to
9bda170
Compare
sfc-gh-bnisco
force-pushed
the
feat-ccv2-dual-test
branch
from
9bda170 to
5177733
Compare
sfc-gh-bnisco
force-pushed
the
feat-ccv2-dual-test
branch
from
5177733 to
5010145
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Added matrix testing for multiple Streamlit versions and updated Playwright tests to support both Custom Component v1 and v2 APIs.
What changed?