[chore] Migrate from setup.py to pyproject #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Nov 20, 2025
Merged
Copilot finished reviewing on behalf of
sfc-gh-lmasuch
November 20, 2025 17:29
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the package configuration by migrating from the legacy setup.py to the standardized pyproject.toml format following PEP 621. The migration updates build processes, removes deprecated files, and ensures GitHub workflows are compatible with the new configuration approach.
Key Changes:
- Replaced
setup.pywithpyproject.tomlfor package metadata and build configuration - Updated GitHub workflows to use modern build tools (
python -m buildinstead ofsetup.py sdist bdist_wheel) - Removed
MANIFEST.inas package data is now explicitly declared in pyproject.toml
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Removed legacy setup.py file containing package configuration |
| pyproject.toml | Added modern PEP 621 compliant configuration with project metadata, dependencies, and build settings |
| MANIFEST.in | Removed as package data is now defined in pyproject.toml's tool.setuptools.package-data section |
| .github/workflows/release.yml | Updated cache keys and build commands to use pyproject.toml and python -m build |
| .github/workflows/playwright.yml | Updated cache keys and build commands to use pyproject.toml and python -m build |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sfc-gh-bnisco
force-pushed
the
feat-ccv2-dual-pyproject
branch
2 times, most recently
from
110cebf to
c9690c7
Compare
sfc-gh-bnisco
force-pushed
the
feat-ccv2-dual-pyproject
branch
from
c9690c7 to
bca5022
Compare
Contributor
Author
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Migrated from
setup.pytopyproject.tomlfor modern Python packaging.What changed?
setup.pywithpyproject.tomlfor package configurationpyproject.tomlinstead ofsetup.pyfor cachingpython -m buildinstead ofpython setup.py sdist bdist_wheelMANIFEST.inas package data is now defined inpyproject.toml