Skip to content

Update Bokeh error message to redirect to streamlit-bokeh custom component#10374

Merged
kmcgrady merged 2 commits into
developfrom
fix/streamlit-bokeh
Feb 18, 2025
Merged

Update Bokeh error message to redirect to streamlit-bokeh custom component#10374
kmcgrady merged 2 commits into
developfrom
fix/streamlit-bokeh

Conversation

@kmcgrady
Copy link
Copy Markdown
Collaborator

Describe your changes

We have launched a bokeh custom component to help support later versions of Bokeh. This change modifies the error message we send to users to encourage them to try out our custom component.

Testing Plan

  • Tests should pass
  • Checked the change looks good visually.
image

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@kmcgrady kmcgrady added security-assessment-completed change:feature PR contains new feature or enhancement implementation impact:users PR changes affect end users labels Feb 11, 2025
Copy link
Copy Markdown
Collaborator

@lukasmasuch lukasmasuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Engineering-wise this LGTM 👍 but maybe another check from @jrieke or @sfc-gh-dmatthews if the message is fine.

If we want to make it even easier for the user, we could add a bit more hands-on example on how to use it:

To use the latest version of Bokeh, just install streamlit-bokeh via:

pip install streamlit-bokeh

and use it like:

from streamlit_bokeh import streamlit_bokeh

streamlit_bokeh(YOUR_BOKEH_FIGURE, use_container_width=True, theme="streamlit", key="my_unique_key")

@lukasmasuch
Copy link
Copy Markdown
Collaborator

btw. I think we can close #5858 with this PR

Comment thread lib/streamlit/elements/bokeh_chart.py Outdated
Co-authored-by: Debbie Matthews <debbie.matthews@snowflake.com>
@kmcgrady kmcgrady merged commit ee0d531 into develop Feb 18, 2025
@kmcgrady kmcgrady deleted the fix/streamlit-bokeh branch February 18, 2025 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change:feature PR contains new feature or enhancement implementation impact:users PR changes affect end users

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants