Skip to content

Fix expander height to use 40px#12015

Merged
lukasmasuch merged 2 commits intodevelopfrom
fix/expander-height
Jul 23, 2025
Merged

Fix expander height to use 40px#12015
lukasmasuch merged 2 commits intodevelopfrom
fix/expander-height

Conversation

@lukasmasuch
Copy link
Copy Markdown
Collaborator

@lukasmasuch lukasmasuch commented Jul 22, 2025

Describe your changes

The expander currently has a total min height of 42px instead of 40px since the border isn't subtracted from the min width.

Testing Plan

  • Update snapshots.

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@snyk-io
Copy link
Copy Markdown
Contributor

snyk-io bot commented Jul 22, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@lukasmasuch lukasmasuch added security-assessment-completed impact:internal PR changes only affect internal code change:bugfix PR contains bug fix implementation labels Jul 22, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 22, 2025

✅ PR preview is ready!

Name Link
📦 Wheel file https://core-previews.s3-us-west-2.amazonaws.com/pr-12015/streamlit-1.47.0-py3-none-any.whl
🕹️ Preview app pr-12015.streamlit.app (☁️ Deploy here if not accessible)

@lukasmasuch lukasmasuch marked this pull request as ready for review July 22, 2025 22:47
Copy link
Copy Markdown
Collaborator

@jrieke jrieke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, sorry for not catching this, thanks for the fix!

@lukasmasuch lukasmasuch merged commit 3e7ea6a into develop Jul 23, 2025
39 checks passed
@lukasmasuch lukasmasuch deleted the fix/expander-height branch July 23, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change:bugfix PR contains bug fix implementation impact:internal PR changes only affect internal code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants