Skip to content

Fix expander accessor return type annotation#14747

Closed
Nikhil-jaiswal007 wants to merge 1 commit intostreamlit:developfrom
Nikhil-jaiswal007:fix-expander-return-type
Closed

Fix expander accessor return type annotation#14747
Nikhil-jaiswal007 wants to merge 1 commit intostreamlit:developfrom
Nikhil-jaiswal007:fix-expander-return-type

Conversation

@Nikhil-jaiswal007
Copy link
Copy Markdown

Describe your changes

Fixed the return type annotation for the expander accessor in lib/streamlit/testing/v1/app_test.py to correctly reflect the expected type signature.

Screenshot or video (only for visual changes)

N/A - This is a purely backend typing update.

GitHub Issue Link (if applicable)

Fixes #[14528] (Note: If you were solving a specific issue on GitHub for this type hint, put the number here so it auto-links. If you just found this typo yourself and there is no issue, you can just delete this whole line).

Testing Plan

Explanation of why no additional tests are needed: This PR only updates a type annotation within the testing framework itself (app_test.py), so no new runtime features were added that require new tests. Local pytest and type checking pass.


Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@snyk-io
Copy link
Copy Markdown
Contributor

snyk-io Bot commented Apr 13, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions
Copy link
Copy Markdown
Contributor

Thanks for contributing to Streamlit! 🎈

Please make sure you have read our Contributing Guide. You can find additional information about Streamlit development in the wiki.

The review process:

  1. Initial triage: A maintainer will apply labels, approve CI to run, and trigger AI-assisted reviews. Your PR may be flagged with status:needs-product-approval if the feature requires product team sign-off.

  2. Code review: A core maintainer will start reviewing your PR once:

    • It is marked as 'ready for review', not 'draft'
    • It has status:product-approved (or doesn't need it)
    • All CI checks pass
    • All AI review comments are addressed

We're receiving many contributions and have limited review bandwidth — please expect some delay. We appreciate your patience! 🙏

@Nikhil-jaiswal007 Nikhil-jaiswal007 deleted the fix-expander-return-type branch April 15, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant