Fix expander accessor return type annotation#14747
Closed
Nikhil-jaiswal007 wants to merge 1 commit intostreamlit:developfrom
Closed
Fix expander accessor return type annotation#14747Nikhil-jaiswal007 wants to merge 1 commit intostreamlit:developfrom
Nikhil-jaiswal007 wants to merge 1 commit intostreamlit:developfrom
Conversation
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
|
Thanks for contributing to Streamlit! 🎈 Please make sure you have read our Contributing Guide. You can find additional information about Streamlit development in the wiki. The review process:
We're receiving many contributions and have limited review bandwidth — please expect some delay. We appreciate your patience! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fixed the return type annotation for the expander accessor in lib/streamlit/testing/v1/app_test.py to correctly reflect the expected type signature.
Screenshot or video (only for visual changes)
N/A - This is a purely backend typing update.
GitHub Issue Link (if applicable)
Fixes #[14528] (Note: If you were solving a specific issue on GitHub for this type hint, put the number here so it auto-links. If you just found this typo yourself and there is no issue, you can just delete this whole line).
Testing Plan
Explanation of why no additional tests are needed: This PR only updates a type annotation within the testing framework itself (app_test.py), so no new runtime features were added that require new tests. Local pytest and type checking pass.
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.