This repository was archived by the owner on Jan 24, 2024. It is now read-only.
Fix linter warnings in GroupMetadataManager and GroupCoordinator#1400
Merged
Conversation
|
@ZiyaoWei:Thanks for your contribution. For this PR, do we need to update docs? |
github-actions
Bot
added
the
doc-info-missing
|
@ZiyaoWei:Thanks for providing doc info! |
github-actions
Bot
added
no-need-doc
ZiyaoWei
force-pushed
the
wzy-group-lints
branch
from
31e1ac9 to
527cb7e
Compare
BewareMyPower
added
release/2.9.2
release/2.8.3
release/2.10.1
type/cleanup
BewareMyPower
approved these changes
Jul 13, 2022
BewareMyPower
added
cherry-picked/branch-2.10.1
release/2.9.3
and removed
release/2.9.2
labels
michaeljmarshall
pushed a commit
to michaeljmarshall/kop
that referenced
this pull request
Dec 13, 2022
…eamnative#1400) ### Motivation Fix linting errors and clean up all the things for the files missed in streamnative#1393. These warnings also masked streamnative#1401 which fixes a bug. ### Modifications Fix the linter warnings. (cherry picked from commit 6f0ecc3)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix linting errors and clean up all the things for the files missed in #1393. These warnings also masked #1401 which fixes a bug.
Modifications
Fix the linter warnings.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation
Check the box below.
Need to update docs?
no-need-docNo client facing functionality changes