This repository was archived by the owner on Jan 24, 2024. It is now read-only.
[WIP] Fix GroupMetadataManager::removeProducerGroup() by using the correct ID#1401
Open
ZiyaoWei wants to merge 1 commit into
Open
[WIP] Fix GroupMetadataManager::removeProducerGroup() by using the correct ID#1401ZiyaoWei wants to merge 1 commit into
ZiyaoWei wants to merge 1 commit into
Conversation
|
@ZiyaoWei:Thanks for your contribution. For this PR, do we need to update docs? |
github-actions
Bot
added
the
doc-info-missing
ZiyaoWei
changed the title
|
@ZiyaoWei:Thanks for providing doc info! |
github-actions
Bot
added
no-need-doc
2 tasks
ZiyaoWei
force-pushed
the
wzy-group-remove-producerId
branch
from
85b344f to
d7ee08d
Compare
BewareMyPower
pushed a commit
that referenced
this pull request
Jul 13, 2022
ZiyaoWei
force-pushed
the
wzy-group-remove-producerId
branch
from
d7ee08d to
7eca2a6
Compare
Collaborator
|
Is it ready to review? If yes, you can remove the "WIP" from the title. |
|
This PR is old. Is it still needed? |
Collaborator
| @@ -673,7 +673,7 @@ private void removeProducerGroup(long producerId, | |||
| } | |||
| } | |||
| openGroupsForProducer.computeIfAbsent(producerId, (pid) -> new HashSet<>()) | |||
Member
There was a problem hiding this comment.
Should we replace the code like this?
openGroupsForProducer.computeIfAbsent(producerId, (pid) -> new HashSet<>())
.remove(groupId);
if (openGroupsForProducer.get(producerId).isEmpty()) {
openGroupsForProducer.remove(producerId);
}
Contributor
Author
|
Will update it - definitely still useful, but it is a bit tricky to find a good way to test the change. I think I'll try to get this merged first and then figure out how to test it, will add a TODO comment. |
michaeljmarshall
pushed a commit
to michaeljmarshall/kop
that referenced
this pull request
Dec 13, 2022
…eamnative#1400) ### Motivation Fix linting errors and clean up all the things for the files missed in streamnative#1393. These warnings also masked streamnative#1401 which fixes a bug. ### Modifications Fix the linter warnings. (cherry picked from commit 6f0ecc3)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
GroupMetadataManager::removeProducerGroup() is trying to remove a group using the producerId.
Modifications
Fixed the issue by using the group ID.
Verifying this change
This change added tests and can be verified as follows:
WIP
Documentation
Check the box below.
Need to update docs?
no-need-docNo functionality change