feat: add allow auto update schema cmd#567
Merged
nodece merged 1 commit intostreamnative:masterfrom Jan 24, 2022
Merged
Conversation
nodece
force-pushed
the
ns_policies_auto_update_schema
branch
2 times, most recently
from
26319a6 to
fd28ca2
Compare
zymap
approved these changes
Jan 24, 2022
|
|
||
| var examples []cmdutils.Example | ||
| examples = append(examples, cmdutils.Example{ | ||
| Desc: "Get allow auto update update schema on a namespace", |
Member
There was a problem hiding this comment.
Suggested change
| Desc: "Get allow auto update update schema on a namespace", | |
| Desc: "Get the whether to allow auto update schema on a namespace", |
Comment on lines
+59
to
+63
| if result != nil { | ||
| vc.Command.Println(strconv.FormatBool(*result)) | ||
| } else { | ||
| vc.Command.Println(result) | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| if result != nil { | |
| vc.Command.Println(strconv.FormatBool(*result)) | |
| } else { | |
| vc.Command.Println(result) | |
| } | |
| vc.Command.Println(strconv.FormatBool(*result)) |
Looks like printing the result directly is enough
Contributor
Author
There was a problem hiding this comment.
We need to check nil pointer.
nodece
force-pushed
the
ns_policies_auto_update_schema
branch
3 times, most recently
from
6a96a9e to
592207c
Compare
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
nodece
force-pushed
the
ns_policies_auto_update_schema
branch
from
592207c to
d1bb3ac
Compare
tisonkun
pushed a commit
to tisonkun/pulsar-client-go
that referenced
this pull request
Aug 15, 2023
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
tisonkun
pushed a commit
to apache/pulsar-client-go
that referenced
this pull request
Aug 16, 2023
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zixuan Liu nodeces@gmail.com