fix: use nil instead of empty string as request body#662
Merged
nodece merged 2 commits intostreamnative:masterfrom Apr 29, 2022
Merged
fix: use nil instead of empty string as request body#662nodece merged 2 commits intostreamnative:masterfrom
nodece merged 2 commits intostreamnative:masterfrom
Conversation
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
codelipenghui
approved these changes
Apr 29, 2022
nodece
added a commit
that referenced
this pull request
Apr 29, 2022
Signed-off-by: Zixuan Liu <nodeces@gmail.com> Co-authored-by: lipenghui <penghui@apache.org> (cherry picked from commit 09f449b)
nodece
added a commit
that referenced
this pull request
Apr 29, 2022
Signed-off-by: Zixuan Liu <nodeces@gmail.com> Co-authored-by: lipenghui <penghui@apache.org> (cherry picked from commit 09f449b)
nodece
added a commit
that referenced
this pull request
Apr 29, 2022
Signed-off-by: Zixuan Liu <nodeces@gmail.com> Co-authored-by: lipenghui <penghui@apache.org> (cherry picked from commit 09f449b)
1 task
nodece
added a commit
that referenced
this pull request
May 9, 2022
Signed-off-by: Zixuan Liu <nodeces@gmail.com> Co-authored-by: lipenghui <penghui@apache.org> (cherry picked from commit 09f449b)
tisonkun
pushed a commit
to tisonkun/pulsar-client-go
that referenced
this pull request
Aug 15, 2023
…lsarctl#662) Signed-off-by: Zixuan Liu <nodeces@gmail.com> Co-authored-by: lipenghui <penghui@apache.org>
tisonkun
pushed a commit
to apache/pulsar-client-go
that referenced
this pull request
Aug 16, 2023
…lsarctl#662) Signed-off-by: Zixuan Liu <nodeces@gmail.com> Co-authored-by: lipenghui <penghui@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zixuan Liu nodeces@gmail.com
Motivation
The empty string does not equal the
nil, if we don't need to pass the request body, we need to use thenil.Modifications
nilinstead of""Documentation
no-need-doc