fix: skip fix_mac_openssl for non-mac os in pulsarctl-security_tool#710
Merged
nodece merged 1 commit intostreamnative:masterfrom May 18, 2022
Merged
Conversation
|
@raohuaming:Thanks for your contribution. For this PR, do we need to update docs? |
github-actions
Bot
added
the
doc-info-missing
nodece
approved these changes
May 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Current plugin security_tool introduced
fix_mac_opensslto fix openssl compatibility issue under Mac OS, but it does not check if the command is under non-Mac OS, which failed running under those situations.Modifications
Describe the modifications you've done.
Just check if the
OSTYPEmatchesdarwin, skipfix_mac_opensslif not.