Skip to content

Build docker image for amd64 linux#774

Merged
nodece merged 1 commit intostreamnative:masterfrom
jiangpengcheng:build_docker
Jul 7, 2022
Merged

Build docker image for amd64 linux#774
nodece merged 1 commit intostreamnative:masterfrom
jiangpengcheng:build_docker

Conversation

@jiangpengcheng
Copy link
Copy Markdown
Member

Motivation

Build a ready-to-use Docker image for pulsarctl

Modifications

Build a docker image for amd64 Linux when release

Verifying this change

  • Make sure that the change passes the CI checks.

  • This change is a trivial rework / code cleanup without any test coverage.

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    doesn't change code for pulsarctl

  • doc

    (If this PR contains doc changes)

@jiangpengcheng jiangpengcheng requested review from a team, nodece and zymap as code owners July 4, 2022 07:31
@github-actions github-actions Bot added the no-need-doc This pr does not need any document label Jul 4, 2022
@jiangpengcheng
Copy link
Copy Markdown
Member Author

@nodece if this pr is merged, do we need to cherry-pick it to other branches?

@zymap
Copy link
Copy Markdown
Member

zymap commented Jul 6, 2022

What's the docker used for?

@nodece
Copy link
Copy Markdown
Contributor

nodece commented Jul 6, 2022

@nodece if this pr is merged, do we need to cherry-pick it to other branches?

Yes, we need to cherry-pick this PR to 2.7, 2.8, 2.9, and 2.10.

@nodece
Copy link
Copy Markdown
Contributor

nodece commented Jul 6, 2022

What's the docker used for?

I guess that want to use the pulsarctl command by docker image.

@nodece nodece merged commit 88ec2c1 into streamnative:master Jul 7, 2022
jiangpengcheng added a commit that referenced this pull request Jul 7, 2022
jiangpengcheng added a commit that referenced this pull request Jul 7, 2022
jiangpengcheng added a commit that referenced this pull request Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-need-doc This pr does not need any document

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants