Skip to content

fix: Remove encoding for the topic#828

Merged
nodece merged 1 commit intostreamnative:masterfrom
nodece:remove-encoding-topic
Sep 14, 2022
Merged

fix: Remove encoding for the topic#828
nodece merged 1 commit intostreamnative:masterfrom
nodece:remove-encoding-topic

Conversation

@nodece
Copy link
Copy Markdown
Contributor

@nodece nodece commented Sep 12, 2022

Fix #827.

Motivation

Topic names are encoded multiple times.

Pulsarctl:

pulsarctl topics create persistent://public/default/topic:12 0

Broker log:

2022-09-12T23:43:46,027+0800 [broker-topic-workers-OrderedExecutor-0-0] INFO  org.apache.pulsar.broker.admin.impl.PersistentTopicsBase - [null] Successfully created non-partitioned topic persistent://public/default/topic%3A12
2022-09-12T23:43:46,028+0800 [broker-topic-workers-OrderedExecutor-0-0] INFO  org.eclipse.jetty.server.RequestLog - 127.0.0.1 - - [12/9月/2022:23:43:45 +0800] "PUT /admi/v2/persistent/public/default/topic%253A12 HTTP/1.1" 204 0 "-" "None" 103

Expected log:

2022-09-12T23:44:36,554+0800 [broker-topic-workers-OrderedExecutor-7-0] INFO  org.apache.pulsar.broker.admin.impl.PersistentTopicsBase - [null] Successfully created non-partitioned topic persistent://public/default/topic:12
2022-09-12T23:44:36,555+0800 [broker-topic-workers-OrderedExecutor-7-0] INFO  org.eclipse.jetty.server.RequestLog - 127.0.0.1 - - [12/9月/2022:23:44:36 +0800] "PUT /admi/v2/persistent/public/default/topic:12 HTTP/1.1" 204 0 "-" "None" 111

Modifications

Remove the GetEncodedTopic() method.

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@nodece nodece requested review from a team and zymap as code owners September 12, 2022 15:41
@github-actions github-actions Bot added doc-info-missing This pr needs to mark a document option in description no-need-doc This pr does not need any document and removed doc-info-missing This pr needs to mark a document option in description labels Sep 12, 2022
@streamnative streamnative deleted a comment from github-actions Bot Sep 13, 2022
@streamnative streamnative deleted a comment from github-actions Bot Sep 13, 2022
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
@nodece nodece force-pushed the remove-encoding-topic branch from 5ebbf55 to 2cb4686 Compare September 13, 2022 01:48
@nodece nodece merged commit f176617 into streamnative:master Sep 14, 2022
nodece added a commit that referenced this pull request Sep 14, 2022
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
(cherry picked from commit f176617)
nodece added a commit that referenced this pull request Sep 14, 2022
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
(cherry picked from commit f176617)
tisonkun pushed a commit to tisonkun/pulsar-client-go that referenced this pull request Aug 15, 2023
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
tisonkun pushed a commit to apache/pulsar-client-go that referenced this pull request Aug 16, 2023
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-need-doc This pr does not need any document

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot create topic names with colons in them.

2 participants