Skip to content
This repository was archived by the owner on Dec 21, 2021. It is now read-only.

Conversation

@bearni95
Copy link
Contributor

Do not pass msgChainId to constructor of ResendFromRequest, as it is unused

@bearni95 bearni95 changed the title Remove references to ResendFromRequest#msgChainId from multiple projects NET-143: Remove references to ResendFromRequest#msgChainId from multiple projects Apr 12, 2021
@linear
Copy link

linear bot commented Apr 12, 2021

NET-143 Remove references to ResendFromRequest#msgChainId from multiple projects

Field msgChainId does not belong in ResendFromRequest as discussed here streamr-dev/streamr-specs#10.

Thus:

  • In network, remove usages of msgChainId from ResendFromRequest
  • In broker, remove usages of msgChainId from ResendFromRequest
  • In broker, make fetching from Cassandra with ResendFromRequest work without msgChainId
  • In streamr-client-javascript, do not pass msgChainId to constructor of ResendFromRequest, as it is unused

bearni95 and others added 10 commits May 17, 2021 12:09
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.19 to 4.17.21.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.19...4.17.21)

Signed-off-by: dependabot[bot] <support@github.com>
Added constants StorageNode.STREAMR_GERMANY and StorageNode.STREAMR_DOCKER_DEV. The values are instances of StorageNode class.

The parameter of addToStorageNode, removeFromStorageNode and getStreamPartsByStorageNode can now be a StorageNode instance or a string.
@bearni95 bearni95 requested a review from harbu May 17, 2021 11:18
Copy link
Contributor

@timoxley timoxley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@timoxley timoxley merged commit e23fa6d into master May 17, 2021
@timoxley timoxley deleted the NET-143 branch May 17, 2021 16:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants