refactor: AddOpeningHours - #6956
Open
paulklie wants to merge 2 commits into
Open
Conversation
westnordost
requested changes
Jul 27, 2026
westnordost
left a comment
Member
There was a problem hiding this comment.
- those are not filters, but filter fragments. the name should make that clear.
- no need for strings to be
lazy
I didn't look at details otherwise
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I refactored AddOpeningHours to make it more legible by splitting up filter into 3 filters:
I did not change the functionality, but did update the comments.
Tested. Tests pass.