Skip to content

refactor: AddOpeningHours - #6956

Open
paulklie wants to merge 2 commits into
streetcomplete:masterfrom
paulklie:refactor_opening_hours
Open

refactor: AddOpeningHours#6956
paulklie wants to merge 2 commits into
streetcomplete:masterfrom
paulklie:refactor_opening_hours

Conversation

@paulklie

@paulklie paulklie commented Jul 25, 2026

Copy link
Copy Markdown
Collaborator

I refactored AddOpeningHours to make it more legible by splitting up filter into 3 filters:

  • namedFilter, for most places, require name or brand
  • unnamedFilter does not require name
  • updateFilter only asked for resurvey

I did not change the functionality, but did update the comments.

Tested. Tests pass.

@westnordost westnordost left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • those are not filters, but filter fragments. the name should make that clear.
  • no need for strings to be lazy

I didn't look at details otherwise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants