export/excel: export special fields#282
Conversation
|
if you approve this idea, I can check to fix these unit tests. |
|
All looks good. Please proceed with writing one or more integration tests. Check out the You mostly need I think I have only written an integration test, not unit tests for Excel export. If you have a good idea of how to unit test this code as well, please feel free to add them as well. ( For integration tests: You can use The idea there is that the If you run everything using Poetry, then you need |
|
Done. |
|
I have checked out your branch and all works and looks good. Could you please I am generally following the following convention for the commit titles:
In this case, something like |
743312f to
f933f43
Compare
f933f43 to
af5f095
Compare
|
@stumpyfr great work! Thanks for rebasing. One itest that could be written later would be to test exporting all possible fields to Excel. But that's another story. |
|
Another heads up: GitHub still does not show you as a contributor. It seems to be the behavior of the GitHub merging strategy when it is set to I will use Again, in case if this matters to you a lot, I didn't know about this behavior of GitHub either and from now on I will use the |
|
no problem :) |
I have worked with the BDD style tests myself but in the context of testing web applications. Applying it to the command line applications is something that I have not considered before. Also, I didn't know about this specific tool. I am going to check it out. Thanks for the hint. |
poetry run strictdoc export ~/Desktop/apex3-4.sdoc --formats=html,excel --fields=uid,statement,owner,priority,parentis now working.