Skip to content

Add pygments to pyproject.toml#463

Merged
stanislaw merged 1 commit intostrictdoc-project:mainfrom
adamgreig:require-pygments
Aug 18, 2021
Merged

Add pygments to pyproject.toml#463
stanislaw merged 1 commit intostrictdoc-project:mainfrom
adamgreig:require-pygments

Conversation

@adamgreig
Copy link
Copy Markdown
Contributor

Thanks for strictdoc, I'm trying it out and really like it so far.

I noticed pygments is a dependency but it's not listed in pyproject.toml, which means a pip installation fails unless you also install pygments separately. It's in the poetry.lock and reqirements.txt, so I guess the CI didn't notice:

/tmp$ python3 -m venv venv
/tmp$ source venv/bin/activate
(venv) /tmp$ pip install strictdoc
Collecting strictdoc
  Using cached strictdoc-0.0.13-py3-none-any.whl (686 kB)
<snip>
Successfully installed Arpeggio-1.10.2 MarkupSafe-2.0.1 XlsxWriter-1.4.5 beautifulsoup4-4.9.3 docutils-0.16 jinja2-2.11.3 python-datauri-0.2.9 soupsieve-2.2.1 strictdoc-0.0.13 textx-2.3.0
(venv) adam@wizard:/tmp$ strictdoc
Traceback (most recent call last):
  File "/tmp/venv/bin/strictdoc", line 5, in <module>
    from strictdoc.cli.main import main
  File "/tmp/venv/lib/python3.8/site-packages/strictdoc/cli/main.py", line 13, in <module>
    from strictdoc.core.actions.export_action import ExportAction
  File "/tmp/venv/lib/python3.8/site-packages/strictdoc/core/actions/export_action.py", line 19, in <module>
    from strictdoc.export.html.html_generator import HTMLGenerator
  File "/tmp/venv/lib/python3.8/site-packages/strictdoc/export/html/html_generator.py", line 29, in <module>
    from strictdoc.export.html.generators.source_file_view_generator import (
  File "/tmp/venv/lib/python3.8/site-packages/strictdoc/export/html/generators/source_file_view_generator.py", line 2, in <module>
    from pygments import highlight
ModuleNotFoundError: No module named 'pygments'

If it's helpful, this PR updates pyproject.toml and the corresponding lock file and bumps the version in requirements.txt to match. No problem if there's some other way you prefer to update them though.

@stanislaw stanislaw merged commit 12a9cde into strictdoc-project:main Aug 18, 2021
@stanislaw
Copy link
Copy Markdown
Collaborator

Good catch! Thank you! I have pushed the new https://pypi.org/project/strictdoc/.

@adamgreig adamgreig deleted the require-pygments branch August 18, 2021 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants