backend/sdoc/grammar: Add GRAMMAR for REFS-TypeValue variant#754
backend/sdoc/grammar: Add GRAMMAR for REFS-TypeValue variant#754stanislaw merged 1 commit intostrictdoc-project:mainfrom
Conversation
stanislaw
left a comment
stanislaw
left a comment
There was a problem hiding this comment.
Excellent work, let's just polish some edges, and please get the branch to pass all tests.
|
Still have to rebase the last commits. |
|
@mettta and I are merging a big branch with some server and web frontend work just now. This is done to avoid big branches and accumulating conflicts. After I am done with some follow-up work related to that branch, I will get to review this your PR again - should do it today. Thank you for your patience. |
|
General comment: I would be curious to learn which problems with itests did you encounter on Windows? |
|
Must setup a new clean testsystem without any old python, pycharm, pip modules or installed in root vs. user space or whatever which could mess up the itest runs. |
stanislaw
left a comment
stanislaw
left a comment
There was a problem hiding this comment.
Hereby approved. Please rebase it one last time and I will merge it.
…arElementFieldReference with ReferenceTypes Add primitive ReferenceType-as-String handling for reqIf and Excel. Update and adding some unit- and itests. FileReference tests RegExpr for differing Linux/Windows OS-Path Normalisation
stanislaw
left a comment
stanislaw
left a comment
There was a problem hiding this comment.
Thank you for addressing all review comments!
|
Do you need a pip package release soon, or you are fine working in a developer mode for now? I need a couple of days to polish and document the new server-related work before I release. Would you mind adding the documentation for the pieces of work that you have contributed? The target document is Also note that I have added a separate https://strictdoc.readthedocs.io/en/latest/strictdoc_11_developer_guide.html. Let me know if you would like any further information to be there to simplify your or others' learning about the development workflow. Thank you. |
|
Working in a developer mode is fine for me. Thx, |
2 participants
Adding ParentReqReference and FileReference TypeValue-Grammar for GRAMMAR-REFS instead of String.
Note: Adding new ExternalReference and updating the Documentation will be done in a separate step.