Skip to content

v0.3.0 β€” Godot MCP Integration#21

Merged
striderZA merged 3 commits into
masterfrom
development
May 2, 2026
Merged

v0.3.0 β€” Godot MCP Integration#21
striderZA merged 3 commits into
masterfrom
development

Conversation

@striderZA

Copy link
Copy Markdown
Owner

Summary

Godot MCP integration β€” provides a runtime feedback loop for automated testing and debugging.

Changes

  • New automated-smoke-test skill: 7-phase workflow β€” verify MCP β†’ launch project β†’ capture debug β†’ analyze errors β†’ report pass/fail β†’ cleanup
  • setup-engine: Added godot-mcp installation/configuration section
  • 5 agents updated with MCP capability references: gameplay-programmer, godot-gdscript-specialist, godot-specialist, ui-programmer, qa-tester
  • .gitattributes: LF line ending normalization
  • Docs: README (73 skills), UPGRADING.md (v0.3.0 section), setup-requirements, quick-start, skills-reference updated
  • Review fixes: process cleanup, timeout/polling, heading levels, version pin, section numbering, DEBUG docs

Verification

  • CI checks pass
  • Review changes per commit

striderZA and others added 2 commits May 2, 2026 07:35
## Summary

Integrates [godot-mcp](https://github.com/Coding-Solo/godot-mcp) to
provide a runtime feedback loop for agents, enabling automated testing,
debugging, and verification of Godot projects.

### Changes

- **`setup-engine` skill**: Added `## 7.5. Configure godot-mcp` section
with installation, configuration, and tool reference docs
- **5 agent files**: Added godot-mcp capability references to
`gameplay-programmer`, `godot-gdscript-specialist`, `godot-specialist`,
`ui-programmer`, and `qa-tester`
- **New `automated-smoke-test` skill**: 7-phase workflow β€” verify MCP β†’
launch project β†’ capture debug β†’ analyze errors β†’ report pass/fail β†’
cleanup
- **Documentation**: Updated `setup-requirements.md`, `quick-start.md`,
and `skills-reference.md`

Closes #15

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: striderZA <striderZA@users.noreply.github.com>
@github-actions

github-actions Bot commented May 2, 2026

Copy link
Copy Markdown
Contributor

PR Review: v0.3.0 β€” Godot MCP Integration

Overview

12 files changed (+354/-12). Adds an automated-smoke-test skill, godot-mCP configuration to setup-engine, MCP capability references to 5 agents, and updates to docs. Generally well-structured, but I found a few issues.


πŸ› Bug: Contradictory skip flow in automated-smoke-test SKILL.md

File: .opencode/skills/automated-smoke-test/SKILL.md:55-58

When run_project times out (no response within 30s), the instruction says:

"Skip to Phase 6 (do not attempt stop)"

But Phase 6 (line 125-129) says:

"Call stop_project via godot-mcp to clean up."

This is contradictory β€” you're sent to the stop phase with instructions not to stop. The timeout case means the project is already hung/unresponsive. It should skip directly to Phase 7 (Report) , since stop_project would likely also time out.

The run_project error case (line 61-63) correctly says "Skip to Phase 7 (Report)" β€” the timeout path should follow the same pattern.

⚠️ Issue: Phase 4 poll error handling β€” ambiguous "last successful output"

File: .opencode/skills/automated-smoke-test/SKILL.md:95-96

"Once polling ends (duration elapsed or early-stop triggered), use the last successful output for analysis."

If the last poll attempt failed (3 consecutive failures triggered the skip), there is no "last successful output" to analyze. The preceding instruction already directed to skip to Phase 6 on 3 consecutive failures, so this code path would be unreachable in that specific scenario β€” but the wording implies there's always a "last successful output" which isn't guaranteed.

⚠️ Issue: Configuration drift in the non-contradictory section

Phase 3, line 57: For the "no response" timeout, says "Skip to Phase 6 (do not attempt stop)" β€” but Phase 6 unconditionally calls stop_project. If you follow line 57 literally, you'd skip the stop call. If you follow Phase 6 literally, you'd try to stop a hung project. This needs a single clear path: skip straight to Phase 7.

πŸ“ Minor: Stale skill count in skills-reference.md

File: .opencode/docs/skills-reference.md:3

68 slash commands organized by phase

The actual count across the project is 73 (per README badges and directory). This was stale before the PR β€” the PR adds 1 more, bringing the effective discrepancy to 73 actual vs. 68 (now 69 with the addition). The header should say 73.

πŸ“ Minor: qa-tester MCP wording

File: .opencode/agents/qa-tester.md:247

Use the godot-mcp server for automated smoke testing: run_project β†’ capture debug output β†’ check for errors

The MCP tool is get_debug_output, not "capture debug output." The agent can't literally "capture" β€” it calls the MCP tool. Consider: "call run_project, poll get_debug_output, and check for errors."

πŸ“ Minor: UPGRADING.md section break placement

File: UPGRADING.md:81

The --- divider between the v0.3.0 section and the "Strategy C β€” Manual file copy" subsection makes Strategy C look like it's nested under v0.3.0, when it's actually a top-level strategy. Consider removing the divider or using appropriate heading levels.


Verdict

Category Finding
Bugs 1 β€” Contradictory skip flow (timeout β†’ Phase 6 β†’ don't stop vs. Phase 6 β†’ stop_project)
Warnings 1 β€” Ambiguous "last successful output" when all polls fail
Minor 3 β€” Stale count, MCP wording, divider placement

Recommendation: Fix the bug in the timeout skip flow before merging (change line 58 from "Skip to Phase 6" to "Skip to Phase 7"). The other items are non-blocking but worth addressing.

New%20session%20-%202026-05-02T05%3A44%3A01.859Z
opencode sessionΒ Β |Β Β github run

@striderZA

Copy link
Copy Markdown
Owner Author

All review items addressed:

Bug (contradictory skip flow): Fixed β€” timeout case now skips to Phase 7 (Report) instead of Phase 6 (stop). Phase 6 would try to stop an already-hung project, worsening the problem.

Ambiguous 'last successful output': Clarified β€” added 'If all polls failed (3 consecutive errors), there is no output to analyze β€” skip directly to the FAIL verdict.'

Stale skill count: Updated skills-reference.md from 68 to 73, and 'Claude Code' β†’ 'OpenCode'.

qa-tester MCP wording: Changed 'capture debug output' β†’ 'call get_debug_output'.

UPGRADING.md divider: Removed the --- separator between v0.3.0 section and Strategy C.

@github-actions

github-actions Bot commented May 2, 2026

Copy link
Copy Markdown
Contributor

Here's my review of the PR:

Issues from auto-review β€” all addressed βœ“

Issue Status
Contradictory skip flow (timeout β†’ Phase 6 vs. Phase 6 says stop) Fixed β€” now skips to Phase 7
Ambiguous "last successful output" wording Fixed β€” clarifies all-polls-failed case
Stale skill count (68β†’73) in skills-reference.md Fixed
qa-tester "capture debug output" β†’ get_debug_output Fixed
UPGRADING.md --- divider between v0.3.0 and Strategy C Removed

Additional findings

Minor β€” Numbering inconsistency in setup-engine/SKILL.md: Section 7's heading ### 7.3. Configure godot-mcp uses numbered subsection prefix while its sibling subsections (### If WITHIN training data and ### If BEYOND training data) do not. This was pre-existing but the new section 7.3 deepens the inconsistency. Should be ### Configure godot-mcp (Optional β€” Godot Only) without the "7.3." prefix.

Minor β€” gameplay-programmer.md MCP wording: Line 135 says "run the project and capture debug output for iterative debugging." This is descriptive rather than tool-specific (unlike the other 4 agent files which list backtick-wrapped tool names). Not wrong, but inconsistent with the pattern used in the other agent files in this PR.

Nit β€” UPGRADING.md Strategy C heading level: ### Strategy C sits under ## v0.3.0, not under ## Upgrade Strategies where ### Strategy A and ### Strategy B live. Makes contextual sense (file lists precede it) but a re-reader could wonder why C lives under v0.3.0 while A/B live under Upgrade Strategies.

Verdict

Category Count Details
Bugs 0 All previously identified bugs fixed
Warnings 0 β€”
Minor 2 Section 7.3 numbering; gameplay-programmer MCP wording consistency

The code changes are clean, the new skill is well-structured with proper error handling at every phase, the agent updates are consistent, and the bot-review findings were correctly resolved. No blocking issues.

New%20session%20-%202026-05-02T05%3A55%3A28.266Z
opencode sessionΒ Β |Β Β github run

@striderZA striderZA merged commit 01ce19f into master May 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant