@feature/agency-enhancement - #6
Merged
Merged
Conversation
Enhance data table components and improve UI consistency - Added 'flush' prop to data-table for better spacing control. - Updated action-cell to include a flex container for better alignment. - Improved empty state messages for clarity and consistency. - Enhanced primary-cell to support mobile titles and clickable rows. - Refactored view-button to use a more consistent button component. - Updated empty-state component to support compact styling. - Improved deliverables and milestones lists with better action handling. - Added mobile row actions for deliverables and milestones. - Enhanced tests to cover new UI states and interactions.
Deliverable Management Refactor deliverable handling by introducing DeliverableFileService for file operations, enhancing code organization and separation of concerns. Updated SaveDeliverable to utilize the new service for file uploads. Improved validation logic in SaveMilestone for status handling.
Refactor project hub resource management and authorization - Introduced AuthorizesProjectHubResources concern to streamline authorization checks across deliverables, meetings, and milestones. - Updated SaveDeliverable, SaveMeeting, and SaveMilestone components to utilize new authorization methods. - Replaced direct authorization calls with centralized methods for better maintainability. - Enhanced DeliverableService, MeetingService, and MilestoneService with project-specific find methods. - Implemented submitForReview functionality for deliverables, allowing admins to submit for client review. - Updated policies to reflect new authorization logic and ensure proper access control for deliverables, meetings, and milestones. - Adjusted frontend components to reflect changes in deliverable actions and messaging. - Added tests to cover new functionality and ensure proper authorization behavior.
Refactor DeliverableService and MilestoneService for milestone synchronization - Updated DeliverableService to utilize MilestoneService for milestone synchronization, enhancing code organization. - Renamed methods for clarity, replacing `updateMilestoneOnDeliverableChange` with `syncMilestoneForDeliverable`. - Introduced `syncFromDeliverables` method in MilestoneService to handle milestone status updates based on deliverable approvals. - Removed redundant milestone status synchronization logic from DeliverableService. - Added tests to verify milestone auto-completion and reopening based on deliverable statuses.
Add feature tests for authorization policies across various resources - Introduced tests for deliverables, credentials, milestones, meetings, projects, and user policies to ensure proper authorization checks. - Verified that admins have full access while clients are restricted based on project ownership. - Implemented tests for creating, viewing, updating, and deleting actions to enforce security measures. - Enhanced coverage for internal and external comment visibility based on user roles.
Updated the docs to better explain project does
Implement file upload functionality for deliverables - Introduced a new FileUploader component to manage file uploads within the SaveDeliverable Livewire component. - Updated SaveDeliverable to handle multiple file uploads, including validation and state management. - Enhanced DeliverableFileService to support batch file uploads and retrieval of active files. - Added policies to manage file access and deletion based on deliverable status. - Updated architecture and configuration files to accommodate new upload limits and storage settings. - Added tests to ensure proper functionality of file uploads and authorization checks.
Enhance deliverable and milestone management with new deletion and confirmation modals - Implemented confirmation modals for submitting deliverables for review and deleting deliverables and milestones. - Updated DeliverablesList and MilestonesList components to handle deletion actions with user confirmation. - Introduced new methods in DeliverableService and MilestoneService to manage deletions based on status and relationships. - Enhanced policies to allow admins to delete draft and rejected deliverables, and empty milestones. - Added UI components for hint disclosures to improve user understanding of deliverable and milestone workflows. - Updated tests to cover new deletion functionalities and ensure proper authorization checks.
Enhance deliverable file management and access control - Added mimeTypeValue method to DeliverableFile model for better MIME type handling. - Implemented isPreviewableImage method to check if the file is an image. - Introduced showUrl method in DeliverableFile for generating file access URLs. - Updated DeliverableFilePolicy to refine download permissions based on deliverable status. - Added findFileForDeliverableInProject method in DeliverableFileService for improved file retrieval. - Refactored downloadFile method to stream files with appropriate headers. - Enhanced save-deliverable view to support read-only mode and improved file upload handling. - Updated deliverables list view to include view actions for in-review deliverables. - Added tests for deliverable file access and permissions, ensuring proper authorization for clients and admins. - Created DeliverableFileAccessTest to validate file access routes and permissions.
Implement credential encryption and reveal functionality - Added encryption for sensitive fields (username, password, url, notes) in the Credential model. - Updated SaveCredentialData to handle sensitive parameters with appropriate attributes. - Refactored ViewCredential component to reveal sensitive details upon user request. - Enhanced CredentialService to manage encrypted credentials and reveal functionality. - Updated tests to validate the encryption process and ensure proper access control for revealing credentials. - Improved UI messaging to inform users about the encryption of sensitive fields.
Update project hub authorization tests and documentation - Refactored project hub authorization tests to improve organization and clarity, moving tests to appropriate directories. - Updated documentation in ARCHITECTURE.md and CONTRIBUTING.md to reflect changes in test structure and project hub authorization coverage. - Added new tests for credentials, deliverables, and meetings to ensure proper authorization checks for admins and clients. - Introduced helper functions for setting up project hub actors in tests, enhancing test readability and maintainability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update project hub authorization tests and documentation