ci: declare contents:read on CI workflow - #102
Merged
Merged
Conversation
CI builds, typechecks, runs biome and pnpm tests, and finally `pnpm publish --dry-run`. None of these reach beyond the working tree. Declaring contents:read at workflow scope makes that intent explicit and matches the workflow-level permissions blocks that release.yml and issue-triggered-create-jira.yml already carry. Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
|
|
|
|
danhill-stripe
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI workflow installs pnpm, runs turbo build, biome, tests, and
pnpm publish --dry-run. It never writes to the repo or comments on PRs. Right now it doesn't declare apermissions:block, so the workflow token gets whatever scope the repository default grants it.Setting
permissions: contents: readpins that to the minimum the steps actually use. Pattern matches:contents: write+pull-requests: write+id-token: writefor changesetscontents: readSo the same shape is already idiomatic here, just missing on ci.yml.
Third-party actions (
pnpm/action-setup,actions/setup-node) are involved; capping the token narrows the blast radius if either is ever compromised (cf. tj-actions/changed-files CVE-2025-30066).