feat: add auth upgrade command to widen access to a superset of permissions - #229
Merged
Merged
Conversation
Committed-By-Agent: claude
selinafeng-stripe
approved these changes
Aug 6, 2026
jlau-stripe
reviewed
Aug 6, 2026
jlau-stripe
left a comment
jlau-stripe
left a comment
Contributor
There was a problem hiding this comment.
Tested locally and overall looks good! Added a note on error handling!
| poll_interval_seconds: authRequest.interval, | ||
| until: 'authenticated is true', | ||
| }, | ||
| cli.command('upgrade', { |
Contributor
There was a problem hiding this comment.
update command without valid params acts like login. It's not harmful but I wonder if it should throw invalid command instead?
The something is just be testing to make sure it still works with invalid input
Contributor
Author
There was a problem hiding this comment.
It looks like this behavior is universal to all Link CLI commands that don't use positional arguments -- see below the payment-methods command has the same issue (see below). I would recommend we ignore for this PR and follow up with a separate change that adds validation messages for unknown positional args, WDYT?
dknudsen@st-dknudsen4(laptop) ~/stripe/link-cli % pnpm run link-cli payment-methods list LASDGLS
> @stripe/link-cli@ link-cli /Users/dknudsen/stripe/link-cli
> ./packages/cli/dist/cli.js payment-methods list LASDGLS
Update available for @stripe/link-cli: 0.10.1 -> 0.11.0
Run: npm install -g @stripe/link-cli
Payment Methods
csmrpd_61VA9dxZ7X53a7oKs412FebmrxrYhERs Chase Savings ****5115
| }); | ||
| scope = merged.mergedScope; | ||
| authorizationDetails = merged.mergedAuthorizationDetails; | ||
| } catch { |
Contributor
There was a problem hiding this comment.
Invalid scope error message is not displayed. Would be nice to have that displayed
Have to use --verbose flag to get the message displayed
Contributor
Author
There was a problem hiding this comment.
I get the same issue for auth login (see below). Since this is a pre-existing issue I'd like to fix it in a separate change, WDYT?
dknudsen@st-dknudsen4(laptop) ~/stripe/link-cli % pnpm run link-cli auth login --scope asdkjgalkgha
> @stripe/link-cli@ link-cli /Users/dknudsen/stripe/link-cli
> ./packages/cli/dist/cli.js auth login --scope asdkjgalkgha
Update available for @stripe/link-cli: 0.10.1 -> 0.11.0
Run: npm install -g @stripe/link-cli
✗ Authentication failed
Device auth initiation failed (400): [object Object]
jlau-stripe
approved these changes
Aug 6, 2026
|
Why don’t you fix my chime account where there money missing so I can pay
my rent , how about that
Damon D Newman
…On Thu, Aug 6, 2026 at 1:39 PM jlau-stripe ***@***.***> wrote:
***@***.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
<#229?email_source=notifications&email_token=BXQZGSXQHF2ZGXDRITFDVM35ITNF3A5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIOBXG43TMNBUGMYKM4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSWGM33PORSXEX3DNRUWG2Y#pullrequestreview-4877764430>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BXQZGSWJI2VJ24QCNPV6MKD5ITNF3AVCNFSNUABGKJSXA33TNF2G64TZHMYTEMJZGQZDINBYHE5US43TOVSTWNJQG42TKNZUG44TRILWAI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
Against keep sending down wild goose chase, I’m telling you your barking up
the wrong tree.
Damon D Newman
…On Thu, Aug 6, 2026 at 1:39 PM jlau-stripe ***@***.***> wrote:
***@***.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
<#229?email_source=notifications&email_token=BXQZGSXQHF2ZGXDRITFDVM35ITNF3A5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIOBXG43TMNBUGMYKM4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSWGM33PORSXEX3DNRUWG2Y#pullrequestreview-4877764430>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BXQZGSWJI2VJ24QCNPV6MKD5ITNF3AVCNFSNUABGKJSXA33TNF2G64TZHMYTEMJZGQZDINBYHE5US43TOVSTWNJQG42TKNZUG44TRILWAI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new command to the CLI,
link-cli auth upgrade [--scope] [--source-actions] [--authorization-details]. The new command unions the requested access with existing access (if any) to create a new login request. Upon success, it revokes and overwrites the existing access token.Motivation
This command provides users and agents an ergonomic shortcut to stepping up their access from agentic-wallet only to add Financial Insights or vice versa. We may eventually provide an in-place upgrade path that doesn't require minting a new credential, but in the meantime this client-only flow is a workable mitigation.
Testing
Upgrade with no active credentials
Upgrade scopes
Upgrade authorization details
Abandoning upgrade mid-flow does not revoke existing auth