Surface object property on EventNotification - #2265
Merged
Merged
Conversation
jar-stripe
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
objectis present in the original payload, but we didn't surface it on theEventNotificationclass. Because ``v2.core.event"` is the only value that will ever be present, It didn't seem worth adding it to the interface.I also wanted to better differentiate
EventNotifications from all otherStripeObjects (since they do behave differently).But, that also means interacting with it along with other objects is unnecessarily complicated. From the original ruby issue:
Because the value is present in the original response, it doesn't make sense to eat it.
What?
objectproperty toEventNotificationSee Also