Fixes the case where previous_attributes is null#291
Merged
olivierbellone merged 2 commits intomasterfrom May 12, 2016
Merged
Conversation
Contributor
|
Thanks for digging into this Olivier! :) |
Contributor
|
A simple test case would be nice, but not required. LGTM |
Contributor
Author
|
@kyleconroy Added a test as you suggested. |
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #290.
In practice, an event's
previous_attributesshould never be set tonull-- it should either be entirely absent from the JSON payload, or have a non-null value if present.However, some of the dummy events sent by the "Send test webhook" button do have
previous_attributes=null. Ideally, we should also fix this, but this PR does make the event deserializer a little more robust.r? @kyleconroy
cc @stripe/api-libraries