Refactor request telemetry#870
Merged
ob-stripe merged 1 commit intointegration-client-refactorfrom Oct 25, 2019
Merged
Conversation
ob-stripe
commented
Oct 25, 2019
| .get("last_request_metrics") | ||
| .getAsJsonObject(); | ||
| String requestId1 = requestMetrics1.get("request_id").getAsString(); | ||
| Long requestDurationMs1 = requestMetrics1.get("request_duration_ms").getAsLong(); |
Contributor
Author
There was a problem hiding this comment.
This is a little bit more awkward because we can no longer deserialize the JSON string into a ClientTelemetryPayload instance so we're using a raw JsonObject instead.
ob-stripe
commented
Oct 25, 2019
remi-stripe
approved these changes
Oct 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @richardm-stripe
cc @stripe/api-libraries
Refactor the request telemetry code into a single
RequestTelemetryclass.Technically a breaking change because
ClientTelemetryPayloadandRequestMetricswere public, though I doubt this will affect many (or any) users.