Skip to content

stripe-java v17#869

Merged
ob-stripe merged 22 commits intomasterfrom
integration-client-refactor
Jan 15, 2020
Merged

stripe-java v17#869
ob-stripe merged 22 commits intomasterfrom
integration-client-refactor

Conversation

@ob-stripe
Copy link
Contributor

@ob-stripe ob-stripe commented Oct 24, 2019

Integration branch for the HTTP client refactoring work.

(⚠️ = breaking changes)

@ob-stripe ob-stripe force-pushed the integration-client-refactor branch 2 times, most recently from 1f126d6 to 692e5ba Compare November 1, 2019 05:00
@ob-stripe ob-stripe force-pushed the integration-client-refactor branch 3 times, most recently from be3e51e to 464ba46 Compare November 16, 2019 04:02
@rattrayalex-stripe
Copy link
Contributor

Can we be sure to include docs on using the retry feature?

@ob-stripe ob-stripe force-pushed the integration-client-refactor branch from 464ba46 to f92ae79 Compare December 10, 2019 22:08
@ob-stripe ob-stripe force-pushed the integration-client-refactor branch from f92ae79 to b07b39b Compare December 23, 2019 19:55
@ob-stripe ob-stripe force-pushed the integration-client-refactor branch 3 times, most recently from 41029aa to dbf5253 Compare January 14, 2020 18:10
@ob-stripe
Copy link
Contributor Author

Okay, I think is ~ready.

I would also like to refactor StripeResponseGetter at some point to turn it into a proper StripeClient that holds configuration values, but that's a bit of a larger refactor that will also require changes to codegen (since right now every resource class creates full URLs by directly relying on the global configuration, e.g. Stripe.getApiBase() + "/v1/customers").

There's no immediate benefit to doing that though, so I'll probably do that in the future when we introduce service classes. For now we can release this which gives us a cleaner/better foundation as well as support for automatic request retries.

@ob-stripe
Copy link
Contributor Author

r? @brandur-stripe @richardm-stripe @remi-stripe
cc @stripe/api-libraries

All PRs have been individually reviewed, so this is really more of a last sweep to see if anything's amiss.

I've also drafted a migration guide to describe the new features and breaking changes: https://github.com/stripe/stripe-java/wiki/%5Bwip%5D-Migration-guide-for-v17.

If there are no objections, I will merge and release this later this week.

@ob-stripe ob-stripe changed the title [wip] HTTP client refactor HTTP client refactor Jan 15, 2020
@ob-stripe ob-stripe changed the title HTTP client refactor stripe-java v17 Jan 15, 2020
@ob-stripe ob-stripe force-pushed the integration-client-refactor branch from 638a211 to bfd3bd2 Compare January 15, 2020 19:07
Copy link
Contributor

@brandur-stripe brandur-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent migration guide!! Looks perfect. One thing I noticed is that it's possible you meant the very last header ("Custom URLStreamHandler") to be an h4 instead of an h3, but I'm not even 100% sure about that.

@ob-stripe
Copy link
Contributor Author

you meant the very last header ("Custom URLStreamHandler") to be an h4 instead of an h3

Good eye! Fixed, thanks :)

@ob-stripe ob-stripe force-pushed the integration-client-refactor branch from bfd3bd2 to 910f6ae Compare January 15, 2020 22:02
@ob-stripe ob-stripe merged commit ec82d87 into master Jan 15, 2020
@ob-stripe ob-stripe deleted the integration-client-refactor branch January 15, 2020 23:07
@ob-stripe
Copy link
Contributor Author

Released as 17.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants