Conversation
1f126d6 to
692e5ba
Compare
be3e51e to
464ba46
Compare
|
Can we be sure to include docs on using the retry feature? |
464ba46 to
f92ae79
Compare
f92ae79 to
b07b39b
Compare
41029aa to
dbf5253
Compare
|
Okay, I think is ~ready. I would also like to refactor There's no immediate benefit to doing that though, so I'll probably do that in the future when we introduce service classes. For now we can release this which gives us a cleaner/better foundation as well as support for automatic request retries. |
|
r? @brandur-stripe @richardm-stripe @remi-stripe All PRs have been individually reviewed, so this is really more of a last sweep to see if anything's amiss. I've also drafted a migration guide to describe the new features and breaking changes: https://github.com/stripe/stripe-java/wiki/%5Bwip%5D-Migration-guide-for-v17. If there are no objections, I will merge and release this later this week. |
638a211 to
bfd3bd2
Compare
brandur-stripe
left a comment
There was a problem hiding this comment.
Excellent migration guide!! Looks perfect. One thing I noticed is that it's possible you meant the very last header ("Custom URLStreamHandler") to be an h4 instead of an h3, but I'm not even 100% sure about that.
Good eye! Fixed, thanks :) |
* Add `CaseInsensitiveMap` class * Add `HttpHeaders` class * Use `HttpHeaders` in `StripeRequest` * Use `HttpHeaders` in `StripeResponse` * Address review comments
bfd3bd2 to
910f6ae
Compare
|
Released as 17.0.0. |
Integration branch for the HTTP client refactoring work.
(⚠️ = breaking changes)
HttpClientclass (Move HTTP request methods into newHttpClientclass #872)StripeRequestobject (AddStripeRequestobject #878)HttpClientabstract class (AddHttpClientabstract class #879)HttpContentclass (AddHttpContentclass #896)Stopwatchclass (AddStopwatchclass #897)StripeRequest(Move all request properties inStripeRequest#898)ApiResource.RequestType(RemoveApiResource.RequestType#899)StringUtilsclass & better API key validation (StringUtilsclass & better API key validation #928)URLStreamHandler(Remove support for customURLStreamHandler#927)StripeResponse(ModernizeStripeResponse#932)maxNetworkRetriesas a global and per-request setting (AddmaxNetworkRetriesas a global and per-request setting #934)StreamUtilsclass (AddStreamUtilsclass #935)countandtotal_countin list objects (Remove support forcountandtotal_countin list objects #936)