Skip to content

Move HTTP request methods into new HttpClient class#872

Merged
ob-stripe merged 1 commit intointegration-client-refactorfrom
ob-refactor-http-client
Oct 26, 2019
Merged

Move HTTP request methods into new HttpClient class#872
ob-stripe merged 1 commit intointegration-client-refactorfrom
ob-refactor-http-client

Conversation

@ob-stripe
Copy link
Contributor

r? @remi-stripe
cc @stripe/api-libraries

  • Move all HTTP related request stuff from LiveStripeResponseGetter into a new HttpClient class
  • Rename LiveStripeResponseGetter.rawRequest to HttpClient.request
  • Initialize an HttpClient instance into LiveStripeResponseGetter
  • Remove LiveStripeResponseGetter.staticRequest/staticOAuthRequest. The request are now sent from the non-static request/oAuthRequest methods, which use the HttpClient instance to send the request
  • Move the request duration computation into HttpClient.request

Not a breaking change, as none of the methods that are affected were public.

@ob-stripe ob-stripe mentioned this pull request Oct 25, 2019
22 tasks
@stripe-ci stripe-ci assigned ob-stripe and unassigned remi-stripe Oct 26, 2019
@ob-stripe ob-stripe merged commit cb8d544 into integration-client-refactor Oct 26, 2019
@ob-stripe ob-stripe deleted the ob-refactor-http-client branch October 26, 2019 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants