Skip to content

Refactors code into different files and other minor changes#27

Closed
HashNuke wants to merge 8 commits intostripe:masterfrom
HashNuke:refactor
Closed

Refactors code into different files and other minor changes#27
HashNuke wants to merge 8 commits intostripe:masterfrom
HashNuke:refactor

Conversation

@HashNuke
Copy link
Copy Markdown
Contributor

Hi there

Changes:

In good faith and as a random response to a tweet - https://twitter.com/avdi/status/202091097906888704

HashNuke added 8 commits May 15, 2012 02:38
Signed-off-by: Akash Manohar J <akash@akash.im>
Signed-off-by: Akash Manohar J <akash@akash.im>
Signed-off-by: Akash Manohar J <akash@akash.im>
Signed-off-by: Akash Manohar J <akash@akash.im>
Signed-off-by: Akash Manohar J <akash@akash.im>
Signed-off-by: Akash Manohar J <akash@akash.im>
Signed-off-by: Akash Manohar J <akash@akash.im>
Signed-off-by: Akash Manohar J <akash@akash.im>
@ebroder
Copy link
Copy Markdown
Contributor

ebroder commented May 14, 2012

Thanks for submitting this! Everything here seems pretty sane and reasonable.

I'm currently planning to do a new release of the stripe gem tomorrow or the day after, and I'd like to be able to review this in a bit more detail than I can before then, so I'm currently not planning to include this in our next release. I'll try to get to this later this week.

@HashNuke
Copy link
Copy Markdown
Contributor Author

Sure Evan,

Take your time :)

Akash Manohar J
http://akash.im
@HashNuke

On Tuesday 15 May 2012 at 3:53 AM, Evan Broder wrote:

Thanks for submitting this! Everything here seems pretty sane and reasonable.

I'm currently planning to do a new release of the stripe gem tomorrow or the day after, and I'd like to be able to review this in a bit more detail than I can before then, so I'm currently not planning to include this in our next release. I'll try to get to this later this week.


Reply to this email directly or view it on GitHub:
#27 (comment)

@goshacmd
Copy link
Copy Markdown

👍

Comment thread lib/stripe.rb
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would use single quotes here

@gdb
Copy link
Copy Markdown
Contributor

gdb commented May 23, 2012

Other than the preceding, looks good! Definitely a huge improvement.

@HashNuke
Copy link
Copy Markdown
Contributor Author

Closing this pull request in favor of new pull request at #28.

Thank you.

@HashNuke HashNuke closed this May 23, 2012
brandur-stripe added a commit that referenced this pull request Apr 5, 2018
Update OpenAPI spec+fixtures so test suite works again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants