Refactors code into different files and other minor changes#27
Refactors code into different files and other minor changes#27HashNuke wants to merge 8 commits intostripe:masterfrom HashNuke:refactor
Conversation
Signed-off-by: Akash Manohar J <akash@akash.im>
Signed-off-by: Akash Manohar J <akash@akash.im>
Signed-off-by: Akash Manohar J <akash@akash.im>
Signed-off-by: Akash Manohar J <akash@akash.im>
Signed-off-by: Akash Manohar J <akash@akash.im>
Signed-off-by: Akash Manohar J <akash@akash.im>
Signed-off-by: Akash Manohar J <akash@akash.im>
Signed-off-by: Akash Manohar J <akash@akash.im>
|
Thanks for submitting this! Everything here seems pretty sane and reasonable. I'm currently planning to do a new release of the stripe gem tomorrow or the day after, and I'd like to be able to review this in a bit more detail than I can before then, so I'm currently not planning to include this in our next release. I'll try to get to this later this week. |
|
Sure Evan, Take your time :) Akash Manohar J On Tuesday 15 May 2012 at 3:53 AM, Evan Broder wrote:
|
|
👍 |
|
Other than the preceding, looks good! Definitely a huge improvement. |
|
Closing this pull request in favor of new pull request at #28. Thank you. |
Update OpenAPI spec+fixtures so test suite works again
Hi there
Changes:
https://github.com/HashNuke/stripe-ruby/pull/new/refactor#L1R13
https://github.com/HashNuke/stripe-ruby/pull/new/refactor#L1L9
Tests now have to be run with
bundle exec rake testor equivalent in rbenv. Running without thebundle execwill fail.In good faith and as a random response to a tweet - https://twitter.com/avdi/status/202091097906888704