Skip to content

Remove stale SpecParser default comments from test-table-modes.ts#144

Merged
kdhillon-stripe merged 2 commits intoextract-metadata-tablefrom
copilot/sub-pr-142
Mar 12, 2026
Merged

Remove stale SpecParser default comments from test-table-modes.ts#144
kdhillon-stripe merged 2 commits intoextract-metadata-tablefrom
copilot/sub-pr-142

Conversation

Copy link

Copilot AI commented Mar 12, 2026

Summary

  • Remove inline comments in test-table-modes.ts that incorrectly stated omitting allowedTables defaults to RUNTIME_REQUIRED_TABLES — this is no longer true after the SpecParser update in Extract metadata table and add visualizer #142 (omitting allowedTables now parses all resolvable x-resourceId entries)
  • Update the all_projected block comment to accurately describe current behavior
  • Remove stale fallback note in the else branch that referenced the old default

Related

Thanks for contributing ❤️


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…_TABLES

Co-authored-by: kdhillon-stripe <243457111+kdhillon-stripe@users.noreply.github.com>
@cla-assistant
Copy link

cla-assistant bot commented Mar 12, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copilot AI changed the title [WIP] [WIP] Address feedback on extracting metadata table and visualizer changes Remove stale SpecParser default comments from test-table-modes.ts Mar 12, 2026
@cla-assistant
Copy link

cla-assistant bot commented Mar 12, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@kdhillon-stripe kdhillon-stripe marked this pull request as ready for review March 12, 2026 04:02
@kdhillon-stripe kdhillon-stripe merged commit 1a51675 into extract-metadata-table Mar 12, 2026
1 check was pending
@kdhillon-stripe kdhillon-stripe deleted the copilot/sub-pr-142 branch March 12, 2026 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants