Skip to content

Remove stale SpecParser default comments from test-table-modes.ts #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kdhillon-stripe merged 2 commits into from
Mar 12, 2026
Merged

Remove stale SpecParser default comments from test-table-modes.ts #144

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02e8d2b
Initial plan
Copilot Mar 12, 2026
e14faf0
Remove stale comments about SpecParser defaulting to RUNTIME_REQUIRED…
Copilot Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions packages/sync-engine/scripts/test-table-modes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,10 @@ async function main() {
console.log(`Table names: ${runtimeRequiredSpec.tables.map((t) => t.tableName).join(', ')}`)
console.log()

// Test all_projected mode (omit allowedTables per the interface documentation)
// Test all_projected mode (omit allowedTables to parse all resolvable x-resourceId entries)
const allProjectedSpec = parser.parse(resolvedSpec.spec, {
resourceAliases: OPENAPI_RESOURCE_TABLE_ALIASES,
// No allowedTables property - per types.ts: "If omitted, all resolvable x-resourceId entries are parsed"
// Note: Current implementation defaults to RUNTIME_REQUIRED_TABLES when omitted
// No allowedTables property - all resolvable x-resourceId entries are parsed
})

console.log('=== all_projected mode ===')
Expand All @@ -67,12 +66,6 @@ async function main() {
additionalTables.forEach((name) => console.log(` - ${name}`))
} else {
console.log('No additional tables found in all_projected mode.')
console.log(
'Note: The SpecParser defaults to RUNTIME_REQUIRED_TABLES when allowedTables is omitted.'
)
console.log(
'This means the parser scope may be the actual bottleneck, not the migration filtering.'
)
}
}

Expand Down