Skip to content

issue-965 yaml conf files#10

Merged
steve-todorov merged 3 commits into
masterfrom
issue-965
Apr 10, 2019
Merged

issue-965 yaml conf files#10
steve-todorov merged 3 commits into
masterfrom
issue-965

Conversation

@fuss86

@fuss86 fuss86 commented Mar 31, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@@ -0,0 +1,84 @@
# General

TODO @sbespalov

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbespalov ,

Would you mind adding some more details here? Thanks! :)


## Configuring The User Access Model

TODO @sbespalov

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbespalov : ... And here as well. :)

- If-Modified-Since
- Cache-Control
- Content-Type
- Content-Range,Range

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ptirador / @fuss86 shouldn't this be - Content-Range and - Range on a new line?

And another question - will this format work as well?

allowedHeaders: ["Accept", "Accepts", "Authorization", ...]

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And another question - will this format work as well?

I don't think so.

YAML's block collections use indentation for scope and begin each member on its own line. Block sequences indicate each member with a dash (“-”).

from

https://yaml.org/spec/1.0/#id2489726

@carlspring

Copy link
Copy Markdown
Member

@strongbox/core-developers,

Should we merge this and have follow-up tasks for the documentation of the things that are still not refactored in regards to the security?

Comment thread docs/user-guide/configuration-files/strongbox-authorization-yaml.md Outdated
@steve-todorov

Copy link
Copy Markdown
Member

Merging this sounds good to me.

@steve-todorov

Copy link
Copy Markdown
Member

Thanks for rebasing @fuss86! I'm going to proceed with merging this. @sbespalov could you please make another PR when you're done with the security related yml files? Thanks!

@steve-todorov steve-todorov merged commit d50a928 into master Apr 10, 2019
@carlspring carlspring deleted the issue-965 branch October 27, 2019 21:03
carlspring pushed a commit that referenced this pull request Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants