Skip to content

Conversation

@bajtos
Copy link
Member

@bajtos bajtos commented Sep 7, 2016

Fix the definition of "data" argument to

{ type: 'object', model: modelName, ... }

That way strong-remoting passed the request body directly to the model
method (does not create a new model instance), but the swagger will
still provide correct schema for these arguments.

This fixes a bug where upsert in relation methods was adding default
property values to request payload.

backport #2702
connect to #1806

Fix the definition of "data" argument to

    { type: 'object', model: modelName, ... }

That way strong-remoting passed the request body directly to the model
method (does not create a new model instance), but the swagger will
still provide correct schema for these arguments.

This fixes a bug where upsert in relation methods was adding default
property values to request payload.
@bajtos bajtos self-assigned this Sep 7, 2016
@bajtos bajtos added the #review label Sep 7, 2016
@bajtos bajtos merged commit f5acf6a into master Sep 7, 2016
@bajtos bajtos deleted the fix/data-object-arguments-3x branch September 7, 2016 12:37
@bajtos bajtos removed the #review label Sep 7, 2016
Amir-61 added a commit that referenced this pull request Sep 7, 2016
Amir-61 added a commit that referenced this pull request Sep 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants