Update globalization structure #2754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@bajtos PTAL |
0candy
force-pushed
the
use_common_globalize
branch
from
586f6c2 to
10c4fd3
Compare
bajtos
suggested changes
Sep 19, 2016
|
|
||
| var g = require('strong-globalize')(); | ||
|
|
||
| var PersistedModel = require('../../lib/loopback').PersistedModel; |
Member
There was a problem hiding this comment.
I think you have accidentally removed reference to PersistedModel. PTAL.
lib/globalize.js
Outdated
| var SG = require('strong-globalize'); | ||
|
|
||
| SG.SetRootDir(path.join(__dirname, '..'), { autonomousMsgLoading: 'all' }); | ||
| module.exports = SG(); No newline at end of file |
Member
There was a problem hiding this comment.
No EOL at EOF, please fix. I thought eslint was configured to catch this, could you PTAL?
0candy
force-pushed
the
use_common_globalize
branch
from
1327a23 to
5b1d919
Compare
Contributor
Author
|
@bajtos Please review |
bajtos
approved these changes
Sep 22, 2016
Member
bajtos
left a comment
bajtos
left a comment
There was a problem hiding this comment.
LGTM, please squash the commits before landing.
bajtos
force-pushed
the
use_common_globalize
branch
from
5b1d919 to
640f3a8
Compare
Member
This failure is caused beuse PhantomJS cannot be started, I think it's ok to ignore. (see https://github.com/strongloop-internal/scrum-loopback/issues/1052) |
Member
|
I squashed the commits myself and landed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow the new approach that's supported by strong-globalize since strongloop/strong-globalize#92.