Skip to content

Conversation

@Amir-61
Copy link
Member

@Amir-61 Amir-61 commented Nov 22, 2016

Connected to https://github.com/strongloop-internal/scrum-epitome/issues/7

  • Remove example/context since it is deprecated in LB 3.0

Connect to https://github.com/strongloop-internal/scrum-loopback/issues/1219

/to: @strongloop/squad-epitome @superkhau @bajtos PTAL.

* Remove `example/context` since it is deprecated in LB 3.0
@Amir-61 Amir-61 self-assigned this Nov 22, 2016
Copy link
Contributor

@superkhau superkhau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- I'll leave it to @bajtos for final say as he is the expert here.

@bajtos
Copy link
Member

bajtos commented Nov 23, 2016

Yes please, let's remove it.

@Amir-61 could you please move the example code to https://github.com/strongloop/loopback-context?

Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Amir-61 Amir-61 merged commit ea4f3ec into master Nov 23, 2016
@Amir-61 Amir-61 deleted the delete_context_example branch November 23, 2016 18:45
@Amir-61 Amir-61 removed the #review label Nov 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants