Skip to content

Conversation

@angfal
Copy link
Contributor

@angfal angfal commented Dec 5, 2017

Description

This reverts commit 1439446

Related issues

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide

@slnode
Copy link

slnode commented Dec 5, 2017

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

@slnode
Copy link

slnode commented Dec 5, 2017

Can one of the admins verify this patch?

3 similar comments
@slnode
Copy link

slnode commented Dec 5, 2017

Can one of the admins verify this patch?

@slnode
Copy link

slnode commented Dec 5, 2017

Can one of the admins verify this patch?

@slnode
Copy link

slnode commented Dec 5, 2017

Can one of the admins verify this patch?

@bajtos
Copy link
Member

bajtos commented Dec 5, 2017

Hello, thank you for the pull request. I am afraid we cannot revert #2842 because it's required for client code-generators to work, see the discussion in #2104.

We need to fix strong-remoting and/or loopback-connector-remote to correctly support anonymously defined types in remote invocations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants