chore: complete Loupe to Loop product rename - #383
Merged
Conversation
cursor Bot
pushed a commit
that referenced
this pull request
Aug 27, 2026
Merge the Loupe-to-Loop rename onto current dev while keeping Phase 5 Widgets deletions. Restore pdftoolenvelopeutils and preflightsidecarutils headers for UnitTestsOperatorAcceptance after the plugin pack removal. Resolves merge conflicts between #383 and dev for the 0.2.0 stack. Co-authored-by: michael berry <mberrys@users.noreply.github.com>
cursor
Bot
force-pushed
the
cdx/loupe-to-loop-rebrand
branch
from
August 27, 2026 17:36
e425fa5 to
3751188
Compare
This was referenced Aug 27, 2026
cursor Bot
pushed a commit
that referenced
this pull request
Aug 27, 2026
Merge the Loupe-to-Loop rename onto current dev while keeping Phase 5 Widgets deletions. Restore pdftoolenvelopeutils and preflightsidecarutils headers for UnitTestsOperatorAcceptance after the plugin pack removal. Resolves merge conflicts between #383 and dev for the 0.2.0 stack. Co-authored-by: michael berry <mberrys@users.noreply.github.com>
cursor
Bot
force-pushed
the
cdx/loupe-to-loop-rebrand
branch
from
August 27, 2026 22:56
3751188 to
f126616
Compare
This was referenced Aug 28, 2026
Contributor
Author
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Merge the Loupe-to-Loop rename onto current dev while keeping Phase 5 Widgets deletions. Restore pdftoolenvelopeutils and preflightsidecarutils headers for UnitTestsOperatorAcceptance after the plugin pack removal. Resolves merge conflicts between #383 and dev for the 0.2.0 stack. Co-authored-by: michael berry <mberrys@users.noreply.github.com>
After rebasing onto dev (#386), Release Gate failed because Session 05 closeout scripts still referenced Loupe targets, loupe-release profile, and docs/loupe-shell.json. Update evidence generators, verifiers, and CI regression tests to use Loop naming and regenerate JSON artifacts. Co-authored-by: michael berry <mberrys@users.noreply.github.com>
UnitTestsPageSurfaceBudget and UnitTestsDocumentViewSession still linked LoupeLibInteraction, LoupeLibCore, and LoupeEditorQuick after the product rename, so Release Gate linux/windows builds could not resolve pagesurfacecoordinator.h and documentviewsession.h. Co-authored-by: michael berry <mberrys@users.noreply.github.com>
Linux Release Gate configures with LOOP_LOOP_DISTRIBUTION=ON, which installs only the consolidated desktop entry. The verify step was still checking the developer profile and would fail on the missing LoopEditor.desktop file. Co-authored-by: michael berry <mberrys@users.noreply.github.com>
The bundled profile id and name changed from loupe-default/Loupe Default to loop-default/Loop Default but kept the old digest, causing profile-digest-mismatch failures in UnitTestsProfileIdentity, UnitTestsPreflightCorpus, and operator acceptance tests on Release Gate. Co-authored-by: michael berry <mberrys@users.noreply.github.com>
Use QGuiApplication::setApplicationDisplayName only when the running instance is a QGuiApplication so core-only builds (fuzz, PdfTool) compile. Pass VCPKG_INSTALLED_DIR to Widgets-absent configure probes so temp build directories reuse the preinstalled vcpkg tree. Co-authored-by: michael berry <mberrys@users.noreply.github.com>
- Restore CMake product identity defines and project(LOOP) - Fix remaining LOUPE tokens in WiX, Windows CI, smoke scripts, and docs - Regenerate architecture and phase5-widgets evidence catalogs - Align loop-release profile naming in contract scripts Co-authored-by: michael berry <mberrys@users.noreply.github.com>
Link LoopLibCore from QuickShellSmoke and CanvasBenchmark so initializeApplicationIdentity() resolves during Widgets-free CI builds. Extract _truncate_command_output() for the release-profile verifier so the regression test matches the configure diagnostic truncation behavior. Co-authored-by: michael berry <mberrys@users.noreply.github.com>
Co-authored-by: michael berry <mberrys@users.noreply.github.com>
QCoreApplication has no applicationDisplayName(); the display name is set via initializeApplicationIdentity on QGuiApplication. Co-authored-by: michael berry <mberrys@users.noreply.github.com>
Widgets-free CI runs QuickShellSmoke from the build tree without install. LoopLibCore.dll lives under usr/bin/Release while the smoke exe defaulted to build/Release, so Windows failed with STATUS_DLL_NOT_FOUND (0xC0000135). Align output directories with ProductQuickAccessibilitySmoke. Co-authored-by: michael berry <mberrys@users.noreply.github.com>
Rebase conflict resolution pulled stable sources with incomplete Loupe→Loop renames in headers, product-surface scripts, and CMake. Restore the Loop identity contract across the affected files. Co-authored-by: michael berry <mberrys@users.noreply.github.com>
cursor
Bot
force-pushed
the
cdx/loupe-to-loop-rebrand
branch
from
August 31, 2026 19:26
02f5008 to
0340ca2
Compare
Co-authored-by: michael berry <mberrys@users.noreply.github.com>
Co-authored-by: michael berry <mberrys@users.noreply.github.com>
After setSettingsPath redirects UserScope IniFormat settings into a temp directory, corruptLegacySettingsDoNotBlockStartup must create the parent path before writing a broken legacy file. Co-authored-by: michael berry <mberrys@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the Loupe → Loop product rename across the repository and establishes
Loopas the canonical product, build, package, and runtime identity.This goes beyond UI/string replacement: it updates source/module names, CMake targets and configuration, CI/release infrastructure, packaging identifiers, application identity, settings, scripts, documentation, and agent/development tooling so the repository no longer depends on the previous Loupe naming.
What changed
LoupeLibCore→LoopLibCoreLoupeLibInteraction→LoopLibInteractionLoupeEditorPlugins→LoopEditorPluginsLOUPE_*toLOOP_*, including version, install, feature, build, and environment variables.LoopLoopio.github.mberrys.Loop-pdfQSettingsdata so existing user preferences can move to the new Loop identity rather than being silently lost.studio-berry/loupetostudio-berry/loop.Compatibility / review notes
This PR intentionally changes developer- and package-facing identifiers as part of completing the rename. The large diff is primarily caused by repository-wide path, target, macro, and identity changes rather than a similarly large expansion in product functionality.
The settings migration is specifically intended to preserve existing configuration where possible across the application identity change.
Reviewers should use rename-aware diff views where possible; raw line-count statistics substantially overstate the amount of logically new code.
Validation
The rename is covered by the existing repository policy/validation infrastructure, including checks around canonical product identity, version configuration, application identity, packaging, documentation consistency, and CI references.
Current CI has already passed:
Fuzz and Release Gate validation are also running against the renamed tree.