fix: unblock Linux package build — PDFForm form detection in QuickDocumentModel - #501
Merged
Merged
Conversation
PDFObject has no isValid() member; use PDFForm::parse to determine whether the catalog exposes an AcroForm or XFA form. Unblocks Linux_AppImage builds. Co-authored-by: michael berry <mberrys@users.noreply.github.com>
mberrys
marked this pull request as ready for review
September 1, 2026 23:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Linux_AppImage run 33557508019 failed during Build Project with:
PDFObjectexposesisNull(),isDictionary(), etc., but notisValid(). Use the existingPDFForm::parsepath (same aspdftoolinfo) to detect AcroForm/XFA presence.Session 07 impact
This is unrelated to the #500 packaging-boundary fixes. Linux cannot reach
linuxdeployqtuntil this compiles. After merge, rerunLinux_AppImagewith the new merged SHA assource_sha.