fix: use JSON console format for AppImage preflight smoke - #526
Merged
mberrys merged 1 commit intoSep 2, 2026
Merged
Conversation
PdfTool preflight only accepts --console-format json. Linux AppImage install smoke still passed text, which would fail after the gperf fix. Windows install smoke already uses json for preflight. Co-authored-by: michael berry <mberrys@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PdfTool
preflightonly accepts--console-format json. Linux AppImage install smoke still passedtext, which would fail on the next packaging qualification run after the gperf fix.Changes
scripts/smoke-test-appimage.sh: switch preflight from--console-format texttojsonscripts/smoke-test-install.ps1) already usesjsonfor preflight, capabilities, and ocr — no changeVerification
preflightcalls with--console-format textpython3 scripts/agent/check-change.py --base origin/cdx/session-07-package-proof— passbash -n scripts/smoke-test-appimage.sh— pass