Fixed #203 Added Shapelet Discovery Tutorial#238
Conversation
|
Check out this pull request on Review Jupyter notebook visual diffs & provide feedback on notebooks. Powered by ReviewNB |
|
@Attol8 Thank you for this wonderful contribution!! I really appreciate that you've taken the time to follow the look/feel of the other existing tutorials and I think the level of information density is great. I love how you've added the I've only read through it quickly but, overall, I think this is ready to be merged. There are some typos and some other minor things that I'd like to add but let that be my problem now. I am more than happy with what you've done! Thank you again and I am already looking forward to your future PR contributions! P.S. Do you happen to have a Twitter handle? I'd like to acknowledge your contribution during our next release |
|
@seanlaw No problem! happy to contribute. Of course, if you see typos or would like to change the style of my comments to be adapted to the docs, feel free to do so. My twitter handle is @JacopoAttolini, I don't use Twitter that much but please do mention me in your tweets, that's very kind of you 😃 |
|
Awesome! Will do |
Shapelet Discovery and Classifier Tutorial
Hi @seanlaw, I have modified a notebook in
/docscontaining an existing tutorial on how to discover shapelets through the MP using STUMPY. I have followed the guidelines that you mentioned to me in issue #85. However, this notebooks solves issue #203. I have started reproducing the paper from this already existing solution as it contained some useful starting code.The new notebook implements:
Let me know how you want to proceed with this. When I have a bit of time I will start implementing other sections of the paper. 😃
Pull Request Checklist
Below is a simple checklist but please do not hesitate to ask for assistance!
black(i.e.,python -m pip install blackorconda install black)flake8(i.e.,python -m pip install flake8orconda install flake8)pytest-cov(i.e.,python -m pip install pytest-covorconda install pytest-cov)black .in the root stumpy directoryflake8 .in the root stumpy directory./setup.sh && ./test.shin the root stumpy directory