Skip to content

Fixed #563 Added parameter atol to motifs/_motifs and docstring#564

Merged
seanlaw merged 2 commits intostumpy-dev:mainfrom
NimaSarajpoor:motif
Mar 6, 2022
Merged

Fixed #563 Added parameter atol to motifs/_motifs and docstring#564
seanlaw merged 2 commits intostumpy-dev:mainfrom
NimaSarajpoor:motif

Conversation

@NimaSarajpoor
Copy link
Copy Markdown
Collaborator

  • add description of atol to docstring
  • pass atol to _motifs( ) when it is called by the function motifs( )

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 6, 2022

Codecov Report

Merging #564 (9f0d1ca) into main (b350b7b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #564   +/-   ##
=======================================
  Coverage   98.93%   98.93%           
=======================================
  Files          74       74           
  Lines       10732    10732           
=======================================
  Hits        10618    10618           
  Misses        114      114           
Impacted Files Coverage Δ
stumpy/motifs.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b350b7b...9f0d1ca. Read the comment docs.

@seanlaw
Copy link
Copy Markdown
Contributor

seanlaw commented Mar 6, 2022

Thank you @NimaSarajpoor. I will merge this once the tests pass

@seanlaw seanlaw changed the title Fixed parameter atol #562 Fixed #562 Added parameter atol to match and docstring Mar 6, 2022
@seanlaw
Copy link
Copy Markdown
Contributor

seanlaw commented Mar 6, 2022

@NimaSarajpoor I could be wrong but I believe that if you name the PR with Fixed #IssueNumber then it will automatically close that issue number when this PR is merged. I don't know what happens if there is additional text between the Fixed and #IssueNumber (i.e., I don't know if Github is smart enough to know how to handle that). The convention is the word Fixed followed directly by #IssueNumber. I've updated the title of this (and the other) PR accordingly.

@NimaSarajpoor
Copy link
Copy Markdown
Collaborator Author

NimaSarajpoor commented Mar 6, 2022

@seanlaw
That is good to know! I did not know about it before! I will consider it from now on.

Btw, I think I added atol to motifs/_motifs (not match which is what title shows). If I am missing something here, please ignore this.

@seanlaw seanlaw changed the title Fixed #562 Added parameter atol to match and docstring Fixed #562 Added parameter atol to motifs/_motifs and docstring Mar 6, 2022
@seanlaw seanlaw merged commit 1e69e3c into stumpy-dev:main Mar 6, 2022
@seanlaw
Copy link
Copy Markdown
Contributor

seanlaw commented Mar 6, 2022

Thanks for handling this @NimaSarajpoor!

@seanlaw seanlaw changed the title Fixed #562 Added parameter atol to motifs/_motifs and docstring Fixed #563 Added parameter atol to motifs/_motifs and docstring Mar 6, 2022
@NimaSarajpoor NimaSarajpoor deleted the motif branch April 28, 2022 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants