Fix: prevent two rel attributes in the same link tag #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Using `cssAttributes` with `rel` property defined doesn't output `rel="stylesheet"` by default anymore - You can now set css or js attributes to an empty string to output only the attribute name (without `=""`) - Update devDependencies
sapegin
requested changes
Jul 22, 2019
Member
sapegin
left a comment
sapegin
left a comment
There was a problem hiding this comment.
Thanks for the pull request!
A have a few comments, and please revert all changes to package files. Tests would be great too!
Collaborator
|
@sapegin Let's merge and publish? |
sapegin
requested changes
Dec 6, 2019
Member
sapegin
left a comment
sapegin
left a comment
There was a problem hiding this comment.
Please ping me when it's ready for another look, I'd never know about that otherwise.
| @@ -0,0 +1 @@ | |||
| import './style.css'; | |||
Member
There was a problem hiding this comment.
Let's move these files to some folder so it's clear they are test files, they shouldn't be in the root folder.
Member
|
@bebraw As soon as it's ready. |
bebraw
added a commit
that referenced
this pull request
Jan 29, 2020
Member
|
🎉 This issue has been resolved in version 2.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cssAttributeswithrelproperty defined doesn't outputrel="stylesheet"by default anymore="")