Skip to content

Conversation

@bebraw
Copy link
Collaborator

@bebraw bebraw commented Jan 29, 2020

Credit: @pldg.

I continued on the work and addressed the comments so we can finally get this one merged.

Closes #12.

@bebraw bebraw requested a review from sapegin January 29, 2020 09:44
Copy link
Member

@sapegin sapegin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♻️

@bebraw bebraw merged commit 88798d1 into master Jan 29, 2020
@bebraw bebraw deleted the fix-rel-attributes branch January 29, 2020 10:07
@bebraw
Copy link
Collaborator Author

bebraw commented Jan 29, 2020

@sapegin Even with the fix: prefix it didn't trigger a release though that's following the commit naming convention. Any idea what's up with that?

@sapegin
Copy link
Member

sapegin commented Jan 29, 2020

You can alway check in the log ;-)

[semantic-release]: node version >=10.18 is required. Found v9.11.2.

@bebraw
Copy link
Collaborator Author

bebraw commented Jan 29, 2020

Ah, let me bump Node version then. I should have checked Travis. Thanks.

@sapegin
Copy link
Member

sapegin commented Jan 29, 2020

🎉 This PR is included in version 2.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants