Fix MG species restart crash#2849
Open
aureliegrebe wants to merge 3 commits into
Open
Conversation
Modify existing axisymmetric compressible species test to add test for MG restart.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Currently, the species solver crashes when restarting a multi-grid simulation due to mismatched grid levels in two calls in
CSpeciesSolver::LoadRestart. This PR fixes that, and modifies a test to exercise this code path.It'd be great if someone could also double-check whether this code makes sense. Given this bug, I suspect these lines have never been run since they were committed 5 years ago.
Related Work
I'll send an accompanying PR for the new restart file needed for the test case.
PR Checklist
pre-commit run --allto format old commits.