Add NEMO governing equations to theory.md #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jtneedels <jneedels@stanford.edu>
Signed-off-by: jtneedels <jneedels@stanford.edu>
Signed-off-by: jtneedels <jneedels@stanford.edu>
pcarruscag
reviewed
Jan 4, 2023
Member
pcarruscag
left a comment
pcarruscag
left a comment
There was a problem hiding this comment.
What is the .DS_Store file?
pcarruscag
reviewed
Jan 4, 2023
_docs_v7/Theory.md
Outdated
|
|
||
| | Solver | Version | | ||
| | --- | --- | | ||
| | `NEMO_NAVIER_STOKES`, `NEMO_RANS` | 7.0.0 | |
Member
There was a problem hiding this comment.
Is NEMO_RANS operational already?
Contributor
Author
There was a problem hiding this comment.
Last I talked to @WallyMaier it works in his branch, but it's not in develop. I think he is still doing V&V. I'll go ahead and remove it for now, and we can add it back in later when ready.
Member
There was a problem hiding this comment.
The documentation and code branches should be in sync (develop -> develop, master -> master)
Contributor
Author
Oops, didn't see that got added. Must be some kind of cache file for when I viewed the md as an html on my machine, I'll remove it. |
Signed-off-by: jtneedels <jneedels@stanford.edu>
Signed-off-by: jtneedels <jneedels@stanford.edu>
pcarruscag
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds governing equations for NEMO solver (nonequilibrium NS and Euler) to theory.md. Work in conjunction with @WallyMaier.