Merged
Conversation
added 5 commits
July 24, 2017 12:03
Member
|
You have conflicts. |
timdmacdo
reviewed
Jul 27, 2017
Contributor
timdmacdo
left a comment
timdmacdo
left a comment
There was a problem hiding this comment.
See my comments and mostly just fix those conflicts
| @@ -147,12 +137,10 @@ def initialize(self,conditions): | |||
| mac = geometry.wings['main_wing'].chords.mean_aerodynamic | |||
| mach = conditions.freestream.mach_number | |||
| AoA = conditions.aerodynamics.angle_of_attack | |||
Contributor
There was a problem hiding this comment.
I actually think it looks better with the spacing in this section. Some of these assignments can be logically separated.
Member
Author
There was a problem hiding this comment.
Ok I will make the relevant changes
Member
There was a problem hiding this comment.
Once things are grouped I am okay with pulling this in.
Contributor
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to the Aerodynamics and Stability AVL functions